From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] Allow pktgen to work with loopback devices. Date: Fri, 09 Mar 2007 11:49:10 -0500 Message-ID: <45F19006.9060607@garzik.org> References: <45EEB011.5020606@freedesktop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Andrew Morton To: Josh Triplett Return-path: In-Reply-To: <45EEB011.5020606@freedesktop.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Josh Triplett wrote: > pktgen currently only works on network devices with type ARPHRD_ETHER. Add > support for the loopback device, type ARPHRD_LOOPBACK. > > I've tested this on my system, using a modified pktgen.conf-1-1 with > s/eth1/lo/g, and it works fine; the network device statistics confirm packet > transmission and receipt. > > Thanks to Sarah Bailey for discovering and tracking down the problem. > > Signed-off-by: Josh Triplett > --- > > I intentionally didn't change the error message "not an ethernet device". For > the purposes of pktgen, loopback devices act like ethernet devices. > > net/core/pktgen.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/core/pktgen.c b/net/core/pktgen.c > index 74a9a32..6fc6f9d 100644 > --- a/net/core/pktgen.c > +++ b/net/core/pktgen.c > @@ -1930,7 +1930,7 @@ static struct net_device *pktgen_setup_dev(struct pktgen_dev *pkt_dev) > printk("pktgen: no such netdevice: \"%s\"\n", pkt_dev->ifname); > goto out; > } > - if (odev->type != ARPHRD_ETHER) { > + if (odev->type != ARPHRD_LOOPBACK && odev->type != ARPHRD_ETHER) { > printk("pktgen: not an ethernet device: \"%s\"\n", > pkt_dev->ifname); I'll let DaveM queue this (or not)