From: Jeff Garzik <jeff@garzik.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, netdev@vger.kernel.org
Subject: Re: [NET] 3c59x: Fix several modpost warnings
Date: Fri, 09 Mar 2007 11:57:30 -0500 [thread overview]
Message-ID: <45F191FA.2070205@garzik.org> (raw)
In-Reply-To: <20070308153316.GA17301@linux-mips.org>
Ralf Baechle wrote:
> WARNING: drivers/net/3c59x.o - Section mismatch: reference to .init.text: from .text between 'vortex_eisa_probe' (at offset 0x4580) and 'vortex_eisa_remove'
> WARNING: drivers/net/3c59x.o - Section mismatch: reference to .init.text: from .text between 'vortex_eisa_probe' (at offset 0x4584) and 'vortex_eisa_remove'
> WARNING: drivers/net/3c59x.o - Section mismatch: reference to .init.text: from .text between 'vortex_eisa_probe' (at offset 0x4588) and 'vortex_eisa_remove'
> WARNING: drivers/net/3c59x.o - Section mismatch: reference to .init.text: from .text between 'vortex_eisa_probe' (at offset 0x458c) and 'vortex_eisa_remove'
>
> Fixed by:
>
> o move definition of vortex_eisa_driver below the functions it references.
> o remove now unnecessary prototypes for vortex_eisa_probe and
> vortex_eisa_remove.
> o Make vortex_eisa_probe an __init function.
> o Make vortex_eisa_remove a __devexit function.
> o Wrap vortex_eisa_driver reference to vortex_eisa_remove with
> __devexit_p().
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
>
> drivers/net/3c59x.c | 28 +++++++++++++---------------
> 1 file changed, 13 insertions(+), 15 deletions(-)
applied this and ibmtr patch
prev parent reply other threads:[~2007-03-09 16:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-08 15:33 [NET] 3c59x: Fix several modpost warnings Ralf Baechle
2007-03-09 16:57 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F191FA.2070205@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).