netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Fix net-2.6.22 on sparc
@ 2007-03-10  0:24 David Miller
  2007-03-10  0:56 ` Eric Dumazet
  0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2007-03-10  0:24 UTC (permalink / raw)
  To: dada1; +Cc: netdev


Eric, please look at whole files you are editing :) I'm sure
there is probably another case like this or two in the
other platform socket ioctl allocations you made.

Thanks.

commit 9415518744729743b017da2e08a71c5bb0d94108
Author: David S. Miller <davem@sunset.davemloft.net>
Date:   Fri Mar 9 16:22:52 2007 -0800

    [NET]: Fix SO_TIMESTAMPNS values allocated to sparc.
    
    They confliced with SO_BROADCAST which already uses the
    value 0x0020.
    
    Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/include/asm-sparc/socket.h b/include/asm-sparc/socket.h
index d77768e..7c14239 100644
--- a/include/asm-sparc/socket.h
+++ b/include/asm-sparc/socket.h
@@ -49,7 +49,7 @@
 
 #define SO_PEERSEC		0x001e
 #define SO_PASSSEC		0x001f
-#define SO_TIMESTAMPNS		0x0020
+#define SO_TIMESTAMPNS		0x0021
 #define SCM_TIMESTAMPNS		SO_TIMESTAMPNS
 
 /* Security levels - as per NRL IPv6 - don't actually do anything */
diff --git a/include/asm-sparc64/socket.h b/include/asm-sparc64/socket.h
index 1bd9f52..986441d 100644
--- a/include/asm-sparc64/socket.h
+++ b/include/asm-sparc64/socket.h
@@ -49,7 +49,7 @@
 
 #define SO_PEERSEC		0x001e
 #define SO_PASSSEC		0x001f
-#define SO_TIMESTAMPNS		0x0020
+#define SO_TIMESTAMPNS		0x0021
 #define SCM_TIMESTAMPNS		SO_TIMESTAMPNS
 
 /* Security levels - as per NRL IPv6 - don't actually do anything */

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: Fix net-2.6.22 on sparc
  2007-03-10  0:24 Fix net-2.6.22 on sparc David Miller
@ 2007-03-10  0:56 ` Eric Dumazet
  2007-03-10  1:00   ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2007-03-10  0:56 UTC (permalink / raw)
  To: David Miller; +Cc: netdev

David Miller a écrit :
> Eric, please look at whole files you are editing :) I'm sure
> there is probably another case like this or two in the
> other platform socket ioctl allocations you made.
> 
> Thanks.
> 
> commit 9415518744729743b017da2e08a71c5bb0d94108
> Author: David S. Miller <davem@sunset.davemloft.net>
> Date:   Fri Mar 9 16:22:52 2007 -0800
> 
>     [NET]: Fix SO_TIMESTAMPNS values allocated to sparc.
>     
>     They confliced with SO_BROADCAST which already uses the
>     value 0x0020.
>     
>     Signed-off-by: David S. Miller <davem@davemloft.net>

Oh I see :( this one was really not easy to spot without close inspection :)

I just checked all arches and only sparc{64} have this strange SO_XXXX values 
not linear. I wonder why this layout was chosen ?


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Fix net-2.6.22 on sparc
  2007-03-10  0:56 ` Eric Dumazet
@ 2007-03-10  1:00   ` David Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2007-03-10  1:00 UTC (permalink / raw)
  To: dada1; +Cc: netdev

From: Eric Dumazet <dada1@cosmosbay.com>
Date: Sat, 10 Mar 2007 01:56:16 +0100

> I just checked all arches and only sparc{64} have this strange
> SO_XXXX values not linear. I wonder why this layout was chosen ?

A lot of the API bogosity in the sparc userspace APIs comes from the
fact that we mirrored the SunOS values at the beginning of the port
and we're kind of stuck with that bad decision. :)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-03-10  1:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-10  0:24 Fix net-2.6.22 on sparc David Miller
2007-03-10  0:56 ` Eric Dumazet
2007-03-10  1:00   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).