From: Jeff Garzik <jeff@garzik.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: shemminger@linux-foundation.org, linux-mips@linux-mips.org,
ralf@linux-mips.org, netdev@vger.kernel.org,
sshtylyov@ru.mvista.com, akpm@linux-foundation.org
Subject: Re: [PATCH] tc35815: Fix an usage of streaming DMA API.
Date: Wed, 14 Mar 2007 05:59:51 -0400 [thread overview]
Message-ID: <45F7C797.4030509@garzik.org> (raw)
In-Reply-To: <20070314.100557.33857330.nemoto@toshiba-tops.co.jp>
Atsushi Nemoto wrote:
> On Tue, 13 Mar 2007 12:04:18 -0700, Stephen Hemminger <shemminger@linux-foundation.org> wrote:
>>> + * 1.35 Fix an usage of streaming DMA API.
>>> */
>> Please don't use comments as changelog anymore. It gets out of date.
>> The use of change control systems has made this practice obsolete.
>
> OK, Jeff, should I send a revised patch dropping this line?
Nah, there's no need to reject the patch on that basis.
You should send an additional patch, on top of all others you sent
recently, that completely removes the entire changelog from the driver
source code :)
Jeff
next prev parent reply other threads:[~2007-03-14 9:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-03 14:54 [PATCH] tc35815 driver update (take 2) Atsushi Nemoto
2007-03-06 11:20 ` Jeff Garzik
2007-03-06 14:13 ` Atsushi Nemoto
2007-03-13 16:02 ` [PATCH] tc35815: Fix an usage of streaming DMA API Atsushi Nemoto
2007-03-13 19:04 ` Stephen Hemminger
2007-03-14 1:05 ` Atsushi Nemoto
2007-03-14 9:59 ` Jeff Garzik [this message]
2007-03-14 15:11 ` Atsushi Nemoto
2007-03-15 15:03 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F7C797.4030509@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=shemminger@linux-foundation.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).