From: Patrick McHardy <kaber@trash.net>
To: Jarek Poplawski <jarkao2@o2.pl>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Robert.Olsson@data.slu.se, tgr@suug.ch
Subject: Re: fib_hash removal
Date: Thu, 15 Mar 2007 08:43:59 +0100 [thread overview]
Message-ID: <45F8F93F.6010408@trash.net> (raw)
In-Reply-To: <20070315074046.GA1671@ff.dom.local>
Jarek Poplawski wrote:
> On 14-03-2007 23:49, Patrick McHardy wrote:
> ...
>
>>I noticed this a couple of times, but didn't manage to look
>>into it yet:
>>
>>BUG: sleeping function called from invalid context at mm/slab.c:3032
>>in_atomic():1, irqs_disabled():0
>>no locks held by ip/14309.
>>
>>Call Trace:
>> [<ffffffff810956e9>] debug_show_held_locks+0x9/0xb
>> [<ffffffff8100b0b0>] __might_sleep+0xd9/0xdb
>> [<ffffffff8100f745>] __kmalloc_track_caller+0x67/0x10f
>> [<ffffffff810aaff1>] __kzalloc+0x15/0x2f
>> [<ffffffff811fc5a5>] tnode_new+0x55/0x122
>
>
> tnode_alloc() uses GFP_KERNEL ...
>
>
>> [<ffffffff811fcc88>] resize+0x616/0x966
>> [<ffffffff811d2e08>] nlmsg_notify+0x43/0x6f
>> [<ffffffff811fd074>] trie_rebalance+0x9c/0xef
>> [<ffffffff811fd231>] trie_leaf_remove+0x16a/0x1c2
>
>
> ... but we have preempt_disable() here.
Yes, Robert already sent me a patch to remove the bogus preempt_disable,
but IIRC it was there to make sure changes to the tree don't interfere
with packet processing, so we might need to do something else. I'll try
to look into it later today.
next prev parent reply other threads:[~2007-03-15 7:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 22:44 fib_hash removal David Miller
2007-03-14 22:49 ` Patrick McHardy
2007-03-15 7:40 ` Jarek Poplawski
2007-03-15 7:43 ` Patrick McHardy [this message]
2007-03-15 9:15 ` Jarek Poplawski
2007-03-15 9:23 ` Jarek Poplawski
2007-03-15 9:42 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F8F93F.6010408@trash.net \
--to=kaber@trash.net \
--cc=Robert.Olsson@data.slu.se \
--cc=davem@davemloft.net \
--cc=jarkao2@o2.pl \
--cc=netdev@vger.kernel.org \
--cc=tgr@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).