From: Kirill Korotaev <dev@sw.ru>
To: devel@openvz.org
Cc: adobriyan@sw.ru, netdev@vger.kernel.org
Subject: Re: [Devel] Re: [PATCH] Copy mac_len in skb_clone() as well
Date: Thu, 15 Mar 2007 13:33:12 +0300 [thread overview]
Message-ID: <45F920E8.4020304@sw.ru> (raw)
In-Reply-To: <20070315.030235.79052031.davem@davemloft.net>
David Miller wrote:
> From: Alexey Dobriyan <adobriyan@sw.ru>
> Date: Wed, 14 Mar 2007 16:07:11 +0300
>
>
>>ANK says: "It is rarely used, that's wy it was not noticed.
>>But in the places, where it is used, it should be disaster."
>>
>>Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
>
>
> Applied.
>
> What bug triggered that helped you discover this? Or is it
> merely from a code audit?
Ohhh, it is a fairy-tale to tell the truth :)
We had some unexplainable problems with java application in OpenVZ kernel.
It didn't work sometimes, but worked fine (!) with CONFIG_SLAB_DEBUG.
Alexey blamed java :), but ...
Then we found that poising one of the bits in slab cache was curing it.
After that we found that the problem is related to fclone cache.
And then we found that not all the fields are initialized during cloning.
The bug was related to our own skb->field we introduced,
but we analyzed the code and found this as well.
Thanks,
Kirill
next prev parent reply other threads:[~2007-03-15 10:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 13:07 [PATCH] Copy mac_len in skb_clone() as well Alexey Dobriyan
2007-03-15 10:02 ` David Miller
2007-03-15 10:33 ` Kirill Korotaev [this message]
2007-03-16 1:08 ` [Devel] " David Miller
2007-03-15 16:04 ` Alexey Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F920E8.4020304@sw.ru \
--to=dev@sw.ru \
--cc=adobriyan@sw.ru \
--cc=devel@openvz.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).