From: Jeff Garzik <jgarzik@pobox.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Chris Stromsoe <cbs@cts.ucla.edu>,
Jay Vosburgh <fubar@us.ibm.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] skge: set mac address bonding fix
Date: Thu, 15 Mar 2007 10:35:19 -0400 [thread overview]
Message-ID: <45F959A7.1090604@pobox.com> (raw)
In-Reply-To: <20070312151626.60d00e30@dxpl.pdx.osdl.net>
Stephen Hemminger wrote:
> When bonding does fail over it calls set_mac_address. When this happens
> as the result of another port going down, the phy_mutex that is common to
> both ports is held, so it deadlocks. Setting the address doesn't need to do
> anything that needs the phy_mutex, it already has the RTNL to protect against
> other admin actions.
>
> This change just disables the receiver to avoid any hardware confusion
> while address is changing.
>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
applied, because:
Rather than guessing about whether hardware confusion would occur, it is
best to disable the receiver (for any hardware) unless we are CERTAIN
that the hardware RX filter can be updated without stopping RX.
Motivated people should check this on other hardware too.
Jeff
next prev parent reply other threads:[~2007-03-15 14:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-08 19:20 skge- "soft lockup on CPU#0" with mtu=9000 (2.6.20.1 + web100 patch) Chris Stromsoe
2007-03-08 19:34 ` Stephen Hemminger
2007-03-08 21:31 ` Chris Stromsoe
2007-03-08 21:48 ` Stephen Hemminger
2007-03-08 22:23 ` Chris Stromsoe
2007-03-08 23:04 ` Jay Vosburgh
2007-03-08 23:13 ` Chris Stromsoe
2007-03-12 22:09 ` Chris Stromsoe
2007-03-12 22:16 ` [PATCH] skge: set mac address bonding fix Stephen Hemminger
2007-03-12 22:39 ` Chris Stromsoe
2007-03-12 23:18 ` Stephen Hemminger
2007-03-13 0:37 ` Chris Stromsoe
2007-03-15 14:35 ` Jeff Garzik [this message]
2007-05-08 22:28 ` skge- "soft lockup on CPU#0" with mtu=9000 (2.6.20.1 + web100 patch) Chris Stromsoe
2007-05-09 0:06 ` Chris Stromsoe
2007-03-08 21:37 ` Jay Vosburgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F959A7.1090604@pobox.com \
--to=jgarzik@pobox.com \
--cc=cbs@cts.ucla.edu \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).