From: Jeff Garzik <jeff@garzik.org>
To: broonie@sirena.org.uk
Cc: Tim Hockin <thockin@hockin.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/3] natsemi: Consistently use interrupt enable/disable functions
Date: Thu, 15 Mar 2007 11:00:20 -0400 [thread overview]
Message-ID: <45F95F84.8030308@garzik.org> (raw)
In-Reply-To: <20070314195156.690711000@sirena.org.uk>
broonie@sirena.org.uk wrote:
> The natsemi drivers include functions for enabling and disabling
> interrupts from the chip but these are not used in all code paths. This
> patch changes the code paths that touch the interrupt enable register to
> use the functions. In all cases this adds an extra PCI read to post the
> operation but since none of these are in fast paths this shouldn't be
> too much of a problem.
>
> Signed-Off-By: Mark Brown <broonie@sirena.org.uk>
applied 1-3 to #upstream-fixes
next prev parent reply other threads:[~2007-03-15 15:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 19:49 [patch 0/3] natsemi updates broonie
2007-03-14 19:49 ` [patch 1/3] natsemi: Consistently use interrupt enable/disable functions broonie
2007-03-15 15:00 ` Jeff Garzik [this message]
2007-03-14 19:49 ` [patch 2/3] natsemi: Fix NAPI for interrupt sharing broonie
2007-03-14 19:49 ` [patch 3/3] natsemi: Avoid IntrStatus lossage if RX state machine resets broonie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F95F84.8030308@garzik.org \
--to=jeff@garzik.org \
--cc=broonie@sirena.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=thockin@hockin.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).