From: Masayuki Nakagawa <nakagawa.msy@ncos.nec.co.jp>
To: yoshfuji@linux-ipv6.org
Cc: netdev@vger.kernel.org, mhuth@mvista.com, nakagawa.msy@ncos.nec.co.jp
Subject: [PATCH 2.6.21-rc3] IPV6: ipv6_fl_socklist is inadvertently shared.
Date: Fri, 16 Mar 2007 10:45:42 -0700 [thread overview]
Message-ID: <45FAD7C6.30305@ncos.nec.co.jp> (raw)
The ipv6_fl_socklist from listening socket is inadvertently shared
with new socket created for connection. This leads to a variety of
interesting, but fatal, bugs. For example, removing one of the
sockets may lead to the other socket's encountering a page fault
when the now freed list is referenced.
The fix is to not share the flow label list with the new socket.
Signed-off-by: Masayuki Nakagawa <nakagawa.msy@ncos.nec.co.jp>
Index: linux-2.6/net/ipv6/tcp_ipv6.c
===================================================================
--- linux-2.6.orig/net/ipv6/tcp_ipv6.c
+++ linux-2.6/net/ipv6/tcp_ipv6.c
@@ -1453,6 +1453,7 @@ static struct sock * tcp_v6_syn_recv_soc
First: no IPv4 options.
*/
newinet->opt = NULL;
+ newnp->ipv6_fl_list = NULL;
/* Clone RX bits */
newnp->rxopt.all = np->rxopt.all;
next reply other threads:[~2007-03-16 17:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-16 17:45 Masayuki Nakagawa [this message]
2007-03-16 23:16 ` [PATCH 2.6.21-rc3] IPV6: ipv6_fl_socklist is inadvertently shared David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45FAD7C6.30305@ncos.nec.co.jp \
--to=nakagawa.msy@ncos.nec.co.jp \
--cc=mhuth@mvista.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).