* [PATCH 2.6.21-rc3] IPV6: ipv6_fl_socklist is inadvertently shared.
@ 2007-03-16 17:45 Masayuki Nakagawa
2007-03-16 23:16 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Masayuki Nakagawa @ 2007-03-16 17:45 UTC (permalink / raw)
To: yoshfuji; +Cc: netdev, mhuth, nakagawa.msy
The ipv6_fl_socklist from listening socket is inadvertently shared
with new socket created for connection. This leads to a variety of
interesting, but fatal, bugs. For example, removing one of the
sockets may lead to the other socket's encountering a page fault
when the now freed list is referenced.
The fix is to not share the flow label list with the new socket.
Signed-off-by: Masayuki Nakagawa <nakagawa.msy@ncos.nec.co.jp>
Index: linux-2.6/net/ipv6/tcp_ipv6.c
===================================================================
--- linux-2.6.orig/net/ipv6/tcp_ipv6.c
+++ linux-2.6/net/ipv6/tcp_ipv6.c
@@ -1453,6 +1453,7 @@ static struct sock * tcp_v6_syn_recv_soc
First: no IPv4 options.
*/
newinet->opt = NULL;
+ newnp->ipv6_fl_list = NULL;
/* Clone RX bits */
newnp->rxopt.all = np->rxopt.all;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.21-rc3] IPV6: ipv6_fl_socklist is inadvertently shared.
2007-03-16 17:45 [PATCH 2.6.21-rc3] IPV6: ipv6_fl_socklist is inadvertently shared Masayuki Nakagawa
@ 2007-03-16 23:16 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-03-16 23:16 UTC (permalink / raw)
To: nakagawa.msy; +Cc: yoshfuji, netdev, mhuth
From: Masayuki Nakagawa <nakagawa.msy@ncos.nec.co.jp>
Date: Fri, 16 Mar 2007 10:45:42 -0700
> The ipv6_fl_socklist from listening socket is inadvertently shared
> with new socket created for connection. This leads to a variety of
> interesting, but fatal, bugs. For example, removing one of the
> sockets may lead to the other socket's encountering a page fault
> when the now freed list is referenced.
>
> The fix is to not share the flow label list with the new socket.
>
> Signed-off-by: Masayuki Nakagawa <nakagawa.msy@ncos.nec.co.jp>
Masayuki-san, thank you very much for this bug fix.
Patch applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-16 23:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-16 17:45 [PATCH 2.6.21-rc3] IPV6: ipv6_fl_socklist is inadvertently shared Masayuki Nakagawa
2007-03-16 23:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).