From: Patrick McHardy <kaber@trash.net>
To: hadi@cyberus.ca
Cc: David Miller <davem@davemloft.net>,
chris@reflexsecurity.com, netdev@vger.kernel.org, tgraf@suug.ch
Subject: Re: Oops in filter add
Date: Tue, 20 Mar 2007 07:58:10 +0100 [thread overview]
Message-ID: <45FF8602.8040108@trash.net> (raw)
In-Reply-To: <1174373645.4895.15.camel@localhost>
jamal wrote:
> On Mon, 2007-19-03 at 19:22 -0700, David Miller wrote:
>
>>It looks like the idea might have been to allow more parallelized
>>running of ingress filters, but this is done wrong and leads to
>>the crashes you are seeing.
>
>
> The main idea is to avoid one BigLock for both ingress and egress;
> Which was/is still useful in the compat mode where netfilter is used
> instead.
In that case is isn't even used.
>>Can you just replace the above with dev->queue_lock and see if
>>that makes your problem go away? THanks.
>
>
> It should;
> i will stare at the code later and see if i can send a better patch,
> maybe a read_lock(qdisc_tree_lock).
You would need to make qdisc_lock_tree() aware of the difference
between ingress and egress.
next prev parent reply other threads:[~2007-03-20 6:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-19 20:10 Oops in filter add Chris Madden
2007-03-20 2:22 ` David Miller
2007-03-20 6:54 ` jamal
2007-03-20 6:58 ` Patrick McHardy [this message]
2007-03-20 7:18 ` jamal
2007-03-20 7:29 ` Patrick McHardy
2007-03-20 9:25 ` jamal
2007-03-20 10:54 ` Chris Madden
2007-03-20 11:02 ` Patrick McHardy
2007-03-20 10:58 ` Patrick McHardy
2007-03-21 9:33 ` jamal
2007-03-20 14:15 ` Chris Madden
2007-03-20 14:48 ` Patrick McHardy
2007-03-20 14:57 ` Patrick McHardy
2007-03-20 15:11 ` Thomas Graf
2007-03-20 15:13 ` Patrick McHardy
2007-03-20 16:27 ` Chris Madden
2007-03-20 17:06 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45FF8602.8040108@trash.net \
--to=kaber@trash.net \
--cc=chris@reflexsecurity.com \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).