netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>,
	syzbot <syzbot+8993c0fa96d57c399735@syzkaller.appspotmail.com>
Cc: davem@davemloft.net, edumazet@google.com,
	linux-kernel@vger.kernel.org, mst@redhat.com,
	netdev@vger.kernel.org, peterpenkov96@gmail.com,
	sd@queasysnail.net, syzkaller-bugs@googlegroups.com,
	willemb@google.com
Subject: Re: KASAN: slab-out-of-bounds Read in tun_net_xmit (2)
Date: Wed, 2 Jan 2019 11:32:03 +0800	[thread overview]
Message-ID: <45aa7f12-ca23-fa23-5d74-985abedb7d8a@redhat.com> (raw)
In-Reply-To: <20181231105143.2b2d2b63@redhat.com>


On 2018/12/31 下午5:51, Jesper Dangaard Brouer wrote:
> Hi MST and Jason,
>
> Could you please take a look at this?  This bug is caused by a thread
> resizing the tun-queue (via tun_queue_resize -> ptr_ring_resize_multiple).
> And error happens in tun_net_xmit -> ptr_ring_produce.  My guess is bug
> happens when reading r->queue in ptr_ring_produce.
>
> I've look at the code (see diff comments below), but I cannot spot the
> issue as the (implicit) memory barrier of a spinlock should cover the
> cases I can imagine.


Hi:

Cong sent a patch for this and looks like it was fixed in 
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=aff6db454599d62191aabc208930e891748e4322.

Thanks

      reply	other threads:[~2019-01-02  3:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-16  8:21 KASAN: slab-out-of-bounds Read in tun_net_xmit (2) syzbot
2018-12-30 18:01 ` syzbot
2018-12-31  9:51   ` Jesper Dangaard Brouer
2019-01-02  3:32     ` Jason Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45aa7f12-ca23-fa23-5d74-985abedb7d8a@redhat.com \
    --to=jasowang@redhat.com \
    --cc=brouer@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=peterpenkov96@gmail.com \
    --cc=sd@queasysnail.net \
    --cc=syzbot+8993c0fa96d57c399735@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).