From: Chris Madden <chris@reflexsecurity.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Thomas Graf <tgraf@suug.ch>, hadi@cyberus.ca, netdev@vger.kernel.org
Subject: Re: Oops in filter add
Date: Tue, 20 Mar 2007 12:27:21 -0400 [thread overview]
Message-ID: <46000B69.8000401@reflexsecurity.com> (raw)
In-Reply-To: <45FFFA36.7080404@trash.net>
Patrick McHardy wrote:
>
> There was a small bug in my patch (broken return value on memory
> allocation failure, not relevant for testing though). I'll push
> the fixed patch to Dave once Chris confirms that it fixes the
> problem he's seeing.
>
Looks like that may have done it. I ramped up the traffic on it and did
thousands of inserts/removals and the box seems happy.
I had ing_filter still locking dev->ingress_lock ( instead of the
queue_lock suggestion earlier ). So while that race may still be in
there, I haven't been able to hit the locking problem.
chris
next prev parent reply other threads:[~2007-03-20 16:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-19 20:10 Oops in filter add Chris Madden
2007-03-20 2:22 ` David Miller
2007-03-20 6:54 ` jamal
2007-03-20 6:58 ` Patrick McHardy
2007-03-20 7:18 ` jamal
2007-03-20 7:29 ` Patrick McHardy
2007-03-20 9:25 ` jamal
2007-03-20 10:54 ` Chris Madden
2007-03-20 11:02 ` Patrick McHardy
2007-03-20 10:58 ` Patrick McHardy
2007-03-21 9:33 ` jamal
2007-03-20 14:15 ` Chris Madden
2007-03-20 14:48 ` Patrick McHardy
2007-03-20 14:57 ` Patrick McHardy
2007-03-20 15:11 ` Thomas Graf
2007-03-20 15:13 ` Patrick McHardy
2007-03-20 16:27 ` Chris Madden [this message]
2007-03-20 17:06 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46000B69.8000401@reflexsecurity.com \
--to=chris@reflexsecurity.com \
--cc=hadi@cyberus.ca \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).