From: Leon Hwang <leon.hwang@linux.dev>
To: bot+bpf-ci@kernel.org, bpf@vger.kernel.org
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
eddyz87@gmail.com, memxor@gmail.com, martin.lau@linux.dev,
song@kernel.org, yonghong.song@linux.dev, jolsa@kernel.org,
emil@etsalapatis.com, ihor.solodrai@linux.dev, hawk@kernel.org,
john.fastabend@gmail.com, sdf@fomichev.me, rostedt@goodmis.org,
mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
shuah@kernel.org, kuniyu@google.com, liuhangbin@gmail.com,
mkarsten@uwaterloo.ca, masashi.honma@gmail.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, martin.lau@kernel.org,
mason@kernel.org
Subject: Re: [PATCH bpf-next 5/6] libbpf: Add bpf_link_create_log API
Date: Mon, 19 Oct 2026 00:33:00 +0800 [thread overview]
Message-ID: <4600eb22-3075-454b-8d6f-d8e01f092e5e@linux.dev> (raw)
In-Reply-To: <d8f51a15d54c296421230d26a3c7b1bb535c9bd98e15eb52dd36344c3690c053@mail.kernel.org>
On 2026/10/17 23:03, bot+bpf-ci@kernel.org wrote:
>> libbpf: Add bpf_link_create_log API
>
> TL;DR: Commit message only: the rationale for adding bpf_link_create_log()
> instead of extending bpf_link_create_opts is vague ("it seems not proper") and
> one sentence is self-contradictory; no code issues raised.
>
>> libbpf: Add bpf_link_create_log API
>>
>> Add a new API to accept the log opts, instead of extending the existing
>> struct bpf_link_create_opts.
>>
>> In the struct bpf_link_create_opts, it seems not proper to append a
>> tailing common log field prior to those variant length fields.
>>
>> Add a new API to avoid breaking the struct bpf_link_create_opts.
>>
>> Signed-off-by: Leon Hwang <leon.hwang@linux.dev>
>
> This isn't a bug, but could the changelog say more concretely why a log
> field cannot be added to struct bpf_link_create_opts (for example, the
> trailing union growing for future link types), rather than "it seems not
> proper"?
>
> The sentence "append a tailing common log field prior to those variant
> length fields" also reads as self-contradictory, since "append" and "prior
> to" point in opposite directions.
Will describe my justification with a concrete case in the next revision.
Thanks,
Leon
>
>
> ---
> AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
> See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
>
> CI run summary: https://github.com/kernel-patches/bpf/actions/runs/39042048581
next prev parent reply other threads:[~2026-10-18 16:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-17 14:26 [PATCH bpf-next 0/6] bpf: Add syscall common attrs support for xdp link_create Leon Hwang
2026-10-17 14:26 ` [PATCH bpf-next 1/6] bpf: Add syscall common attrs support for link_create Leon Hwang
2026-10-17 14:26 ` [PATCH bpf-next 2/6] bpf: Add syscall common attrs support for xdp link_create Leon Hwang
2026-10-17 15:03 ` bot+bpf-ci
2026-10-18 16:30 ` Leon Hwang
2026-10-17 14:26 ` [PATCH bpf-next 3/6] bpf: Retire tracepoint bpf_xdp_link_attach_failed Leon Hwang
2026-10-17 14:26 ` [PATCH bpf-next 4/6] libbpf: Factor out __bpf_sys_fd helper Leon Hwang
2026-10-17 14:53 ` bot+bpf-ci
2026-10-18 16:32 ` Leon Hwang
2026-10-17 14:26 ` [PATCH bpf-next 5/6] libbpf: Add bpf_link_create_log API Leon Hwang
2026-10-17 15:03 ` bot+bpf-ci
2026-10-18 16:33 ` Leon Hwang [this message]
2026-10-17 14:26 ` [PATCH bpf-next 6/6] selftests/bpf: Add tests to verify link_create logs Leon Hwang
2026-10-17 15:02 ` bot+bpf-ci
2026-10-18 16:33 ` Leon Hwang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4600eb22-3075-454b-8d6f-d8e01f092e5e@linux.dev \
--to=leon.hwang@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bot+bpf-ci@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@kernel.org \
--cc=emil@etsalapatis.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ihor.solodrai@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=martin.lau@kernel.org \
--cc=martin.lau@linux.dev \
--cc=masashi.honma@gmail.com \
--cc=mason@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=memxor@gmail.com \
--cc=mhiramat@kernel.org \
--cc=mkarsten@uwaterloo.ca \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox