* Fix return code in pci-skeleton.c
@ 2007-03-16 22:00 Anton Blanchard
2007-03-23 5:49 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Anton Blanchard @ 2007-03-16 22:00 UTC (permalink / raw)
To: netdev, jeff
We assign the return value of register_netdev to i, but return rc later
on. Fix it.
Signed-off-by: Anton Blanchard <anton@samba.org>
---
diff --git a/drivers/net/pci-skeleton.c b/drivers/net/pci-skeleton.c
index 00ca0fd..6ca4e4f 100644
--- a/drivers/net/pci-skeleton.c
+++ b/drivers/net/pci-skeleton.c
@@ -710,8 +710,8 @@ match:
tp->chipset,
rtl_chip_info[tp->chipset].name);
- i = register_netdev (dev);
- if (i)
+ rc = register_netdev (dev);
+ if (rc)
goto err_out_unmap;
DPRINTK ("EXIT, returning 0\n");
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: Fix return code in pci-skeleton.c
2007-03-16 22:00 Fix return code in pci-skeleton.c Anton Blanchard
@ 2007-03-23 5:49 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-03-23 5:49 UTC (permalink / raw)
To: Anton Blanchard; +Cc: netdev
Anton Blanchard wrote:
> We assign the return value of register_netdev to i, but return rc later
> on. Fix it.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
> ---
>
> diff --git a/drivers/net/pci-skeleton.c b/drivers/net/pci-skeleton.c
> index 00ca0fd..6ca4e4f 100644
> --- a/drivers/net/pci-skeleton.c
> +++ b/drivers/net/pci-skeleton.c
> @@ -710,8 +710,8 @@ match:
> tp->chipset,
> rtl_chip_info[tp->chipset].name);
>
> - i = register_netdev (dev);
> - if (i)
> + rc = register_netdev (dev);
> + if (rc)
> goto err_out_unmap;
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-23 5:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-16 22:00 Fix return code in pci-skeleton.c Anton Blanchard
2007-03-23 5:49 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).