From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: shemminger@linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH 4/5] netem: avoid excessive requeues
Date: Fri, 23 Mar 2007 14:26:15 +0100 [thread overview]
Message-ID: <4603D577.4010509@trash.net> (raw)
In-Reply-To: <4603B4A6.7050202@trash.net>
Patrick McHardy wrote:
> David Miller wrote:
>
>>>Perhaps we should put this in qdisc_restart, other qdiscs have the
>>>same problem.
>>
>>
>>Agreed, patches welcome :)
>
>
> I've tried this, but for some reason it makes TBF stay about
> 5% under the configured rate. Probably because of late timers,
> the strange thing is that the 5% happen constantly even with
> very low rates.
Turns out it was a mistake during testing, I measured on the
ethernet device that is also used by my PPPoE connection, which
had some traffic too. iptraf only measures IP packets, so it
didn't show the bandwidth used by PPPoE.
Patch coming up :)
next prev parent reply other threads:[~2007-03-23 13:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-21 17:42 [PATCH 0/5] netem performance improvements Stephen Hemminger
2007-03-21 17:42 ` [PATCH 1/5] netem: report reorder percent correctly Stephen Hemminger
2007-03-21 17:42 ` [PATCH 2/5] netem: use better types for time values Stephen Hemminger
2007-03-21 17:42 ` [PATCH 3/5] netem: optimize tfifo Stephen Hemminger
2007-03-21 17:42 ` [PATCH 4/5] netem: avoid excessive requeues Stephen Hemminger
2007-03-22 20:40 ` Patrick McHardy
2007-03-22 21:08 ` David Miller
2007-03-23 11:06 ` Patrick McHardy
2007-03-23 13:26 ` Patrick McHardy [this message]
2007-03-21 17:42 ` [PATCH 5/5] qdisc: avoid transmit softirq on watchdog wakeup Stephen Hemminger
2007-03-22 19:19 ` [PATCH 0/5] netem performance improvements David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4603D577.4010509@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).