From: Patrick McHardy <kaber@trash.net>
To: James Chapman <jchapman@katalix.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/5 2.6.21-rc4] l2tp: pppol2tp changes to existing kernel headers
Date: Sat, 24 Mar 2007 15:00:55 +0100 [thread overview]
Message-ID: <46052F17.9000802@trash.net> (raw)
In-Reply-To: <200703232307.l2NN7ROx010811@quickie.katalix.com>
James Chapman wrote:
> +/* For PPPIOCGL2TPSTATS */
> +struct pppol2tp_ioc_stats {
> + __u16 tunnel_id; /* redundant */
> + __u16 session_id; /* if zero, get tunnel stats */
This leaves a 32 bit hole. Maybe move using_ipsec up.
> + __u64 tx_packets;
> + __u64 tx_bytes;
> + __u64 tx_errors;
> + __u64 rx_packets;
> + __u64 rx_bytes;
> + __u64 rx_seq_discards;
> + __u64 rx_oos_packets;
> + __u64 rx_errors;
> + int using_ipsec; /* valid only for session_id == 0 */
> +};
prev parent reply other threads:[~2007-03-24 14:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-23 23:07 [PATCH 2/5 2.6.21-rc4] l2tp: pppol2tp changes to existing kernel headers James Chapman
2007-03-24 14:00 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46052F17.9000802@trash.net \
--to=kaber@trash.net \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).