From: Patrick McHardy <kaber@trash.net>
To: James Chapman <jchapman@katalix.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/5 2.6.21-rc4] l2tp: pppol2tp core
Date: Sat, 24 Mar 2007 22:58:16 +0100 [thread overview]
Message-ID: <46059EF8.6050603@trash.net> (raw)
In-Reply-To: <200703232307.l2NN7Rtg010808@quickie.katalix.com>
James Chapman wrote:
> [PPPOL2TP]: Add PPP-over-L2TP driver core.
A couple more comments:
- seq_file handling doesn't check seq_printf return values and
tries to dump the entire hash table at once, which might
exceed the available room.
- there appear to be no checks for duplicate session IDs on
session creation.
- try_module_get/put_module in pppol2tp_create look unnecessary
- kfree can take NULL pointers
- direct dereference of user pointer in pppol2tp_sendmsg debugging
- jiffies.h includes conversion functions for HZ <-> msecs
- Any particular reason why the SKB_CB is put after inet_skb_parm?
On 64 bit this almost reaches the limit, might be safer to put
it at the beginning.
next prev parent reply other threads:[~2007-03-24 21:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-23 23:07 [PATCH 1/5 2.6.21-rc4] l2tp: pppol2tp core James Chapman
2007-03-24 0:22 ` Florian Zumbiehl
2007-03-24 17:37 ` James Chapman
2007-03-24 18:07 ` Florian Zumbiehl
2007-03-24 14:03 ` Patrick McHardy
2007-03-24 19:01 ` James Chapman
2007-03-24 19:26 ` David Miller
2007-03-24 20:56 ` Patrick McHardy
2007-03-25 16:00 ` James Chapman
2007-03-27 14:37 ` Patrick McHardy
2007-03-24 21:58 ` Patrick McHardy [this message]
2007-03-25 16:12 ` James Chapman
2007-03-27 11:32 ` Ingo Oeser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46059EF8.6050603@trash.net \
--to=kaber@trash.net \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).