From: Eric Dumazet <dada1@cosmosbay.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] NET : inet_ehash_secret should be __read_mostly and set only once
Date: Tue, 27 Mar 2007 23:03:06 +0200 [thread overview]
Message-ID: <4609868A.5030103@cosmosbay.com> (raw)
In-Reply-To: <20070327.135338.77404865.davem@davemloft.net>
David Miller a écrit :
> From: Eric Dumazet <dada1@cosmosbay.com>
> Date: Tue, 27 Mar 2007 12:13:43 +0200
>
>> Hi David
>>
>> Please find this patch against net-2.6.22
>>
>> Thank you
>>
>> [PATCH] NET : inet_ehash_secret should be __read_mostly and set only once
>>
>> There is a very tiny probability that build_ehash_secret() is called at the same time by different CPUS.
>>
>> Also, using __read_mostly is a must for inet_ehash_secret
>>
>> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
>
> Applied, but I left out this totally unrelated code formatting
> change in your patch:
>
>> @@ -684,7 +694,8 @@ int inet_sendmsg(struct kiocb *iocb, str
>> }
>>
>>
>> -static ssize_t inet_sendpage(struct socket *sock, struct page *page, int offset, size_t size, int flags)
>> +static ssize_t inet_sendpage(struct socket *sock, struct page *page, int offset,
>> + size_t size, int flags)
>> {
>> struct sock *sk = sock->sk;
>>
Well... just a minor change to reduce length of this too long line...
prev parent reply other threads:[~2007-03-27 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-27 10:13 [PATCH] NET : inet_ehash_secret should be __read_mostly and set only once Eric Dumazet
2007-03-27 20:53 ` David Miller
2007-03-27 21:03 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4609868A.5030103@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).