* [PATCH] atl1: remove unnecessary crc inversion
@ 2007-03-28 0:43 Jay Cliburn
2007-03-28 6:19 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Jay Cliburn @ 2007-03-28 0:43 UTC (permalink / raw)
To: jeff; +Cc: csnook, netdev, linux-kernel, jareguero, atl1-devel
From: Jay Cliburn <jacliburn@bellsouth.net>
The original vendor driver contained a private ether_crc_le() function
that produced an inverted crc. When we changed to the kernel version of
ether_crc_le(), we neglected to undo the inversion. Let's do it now.
Discovered by and patch proffered by Jose Alberto Reguero.
Signed-off-by: Jose Alberto Reguero <jareguero@telefonica.net>
Signed-off-by: Jay Cliburn <jacliburn@bellsouth.net>
---
drivers/net/atl1/atl1_hw.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/atl1/atl1_hw.c b/drivers/net/atl1/atl1_hw.c
index 314dbaa..69482e0 100644
--- a/drivers/net/atl1/atl1_hw.c
+++ b/drivers/net/atl1/atl1_hw.c
@@ -334,7 +334,6 @@ u32 atl1_hash_mc_addr(struct atl1_hw *hw, u8 *mc_addr)
int i;
crc32 = ether_crc_le(6, mc_addr);
- crc32 = ~crc32;
for (i = 0; i < 32; i++)
value |= (((crc32 >> i) & 1) << (31 - i));
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] atl1: remove unnecessary crc inversion
2007-03-28 0:43 [PATCH] atl1: remove unnecessary crc inversion Jay Cliburn
@ 2007-03-28 6:19 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-03-28 6:19 UTC (permalink / raw)
To: Jay Cliburn; +Cc: csnook, netdev, linux-kernel, jareguero, atl1-devel
Jay Cliburn wrote:
> From: Jay Cliburn <jacliburn@bellsouth.net>
>
> The original vendor driver contained a private ether_crc_le() function
> that produced an inverted crc. When we changed to the kernel version of
> ether_crc_le(), we neglected to undo the inversion. Let's do it now.
> Discovered by and patch proffered by Jose Alberto Reguero.
>
> Signed-off-by: Jose Alberto Reguero <jareguero@telefonica.net>
> Signed-off-by: Jay Cliburn <jacliburn@bellsouth.net>
applied to #upstream-fixes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-28 6:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-28 0:43 [PATCH] atl1: remove unnecessary crc inversion Jay Cliburn
2007-03-28 6:19 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).