From: Jeff Garzik <jeff@garzik.org>
To: Chris Snook <csnook@redhat.com>
Cc: xiong.huang@atheros.com, jacliburn@bellsouth.net, netdev@vger.kernel.org
Subject: Re: [PATCH] add Attansic L2 PCI ID
Date: Thu, 29 Mar 2007 08:23:12 -0400 [thread overview]
Message-ID: <460BAFB0.7000408@garzik.org> (raw)
In-Reply-To: <20070328234738.GA8042@devserv.devel.redhat.com>
Chris Snook wrote:
> From: Chris Snook <csnook@redhat.com>
>
> Add PCI ID for the Attansic L2 100 Mb ethernet adapter.
>
> Signed-off-by: Chris Snook <csnook@redhat.com>
>
> --- linux-2.6.21-rc5.orig/include/linux/pci_ids.h 2007-03-27 23:26:50.000000000 -0400
> +++ linux-2.6.21-rc5/include/linux/pci_ids.h 2007-03-28 15:11:03.000000000 -0400
> @@ -2090,6 +2090,7 @@
>
> #define PCI_VENDOR_ID_ATTANSIC 0x1969
> #define PCI_DEVICE_ID_ATTANSIC_L1 0x1048
> +#define PCI_DEVICE_ID_ATTANSIC_L2 0x2048
Actually you should be doing the reverse:
Remove PCI_DEVICE_ID_ATTANSIC_L1, and replace the one place that uses it
with the hexadecimal constant.
Jeff
next prev parent reply other threads:[~2007-03-29 12:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-28 23:47 [PATCH] add Attansic L2 PCI ID Chris Snook
2007-03-29 12:23 ` Jeff Garzik [this message]
2007-03-29 14:11 ` Chris Snook
2007-03-29 18:56 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460BAFB0.7000408@garzik.org \
--to=jeff@garzik.org \
--cc=csnook@redhat.com \
--cc=jacliburn@bellsouth.net \
--cc=netdev@vger.kernel.org \
--cc=xiong.huang@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).