[PATCH] atl1: save mac address on remove

[PATCH] atl1: save mac address on remove

[Chris Snook]

From: Chris Snook <csnook@redhat.com>

Some atl1 boards get their MAC address written directly to the register
by the BIOS during POST, rather than storing it in EEPROM that's
accessible to the driver.  If the MAC register on one of these boards
is changed and then the module is unloaded, the permanent MAC address
will be forgotten until the box is rebooted.  We should save the
permanent address during removal if we've been messing with it.

Signed-off-by: Chris Snook <csnook@redhat.com>

--- a/drivers/net/atl1/atl1_main.c	2007-03-01 14:14:48.000000000 -0500
+++ b/drivers/net/atl1/atl1_main.c	2007-03-01 16:59:59.000000000 -0500
@@ -2321,6 +2321,16 @@ static void __devexit atl1_remove(struct
 		return;
 
 	adapter = netdev_priv(netdev);
+
+	/* Some atl1 boards lack persistent storage for their MAC, and get it
+	 * from the BIOS during POST.  If we've been messing with the MAC
+	 * address, we need to save the permanent one.
+	 */
+	if (memcmp(adapter->hw.mac_addr, adapter->hw.perm_mac_addr, ETH_ALEN)) {
+		memcpy(adapter->hw.mac_addr, adapter->hw.perm_mac_addr, ETH_ALEN);
+		atl1_set_mac_addr(&adapter->hw);
+	}
+
 	iowrite16(0, adapter->hw.hw_addr + REG_GPHY_ENABLE);
 	unregister_netdev(netdev);
 	pci_iounmap(pdev, adapter->hw.hw_addr);

Re: [PATCH] atl1: save mac address on remove

[Jeff Garzik]

Chris Snook wrote:
> From: Chris Snook <csnook@redhat.com>
> 
> Some atl1 boards get their MAC address written directly to the register
> by the BIOS during POST, rather than storing it in EEPROM that's
> accessible to the driver.  If the MAC register on one of these boards
> is changed and then the module is unloaded, the permanent MAC address
> will be forgotten until the box is rebooted.  We should save the
> permanent address during removal if we've been messing with it.
> 
> Signed-off-by: Chris Snook <csnook@redhat.com>

applied, even though its a hack

Re: [PATCH] atl1: save mac address on remove

[Chris Snook]

Jeff Garzik wrote:
> Chris Snook wrote:
>> From: Chris Snook <csnook@redhat.com>
>>
>> Some atl1 boards get their MAC address written directly to the register
>> by the BIOS during POST, rather than storing it in EEPROM that's
>> accessible to the driver.  If the MAC register on one of these boards
>> is changed and then the module is unloaded, the permanent MAC address
>> will be forgotten until the box is rebooted.  We should save the
>> permanent address during removal if we've been messing with it.
>>
>> Signed-off-by: Chris Snook <csnook@redhat.com>
> 
> applied, even though its a hack

Oh, it's definitely a hack, but the hardware it's supporting is a hack, so we 
have to work with it.

Thanks.

	-- Chris