From: Jeff Garzik <jeff@garzik.org>
To: Dale Farnsworth <dale@farnsworth.org>
Cc: Gabriel Paubert <paubert@iram.es>,
Manish Lachwani <mlachwani@mvista.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] mv643xx_eth: make eth_port_uc_addr_{get,set}() calls symmetric
Date: Thu, 29 Mar 2007 08:35:18 -0400 [thread overview]
Message-ID: <460BB286.2030706@garzik.org> (raw)
In-Reply-To: <20070323190726.GA4736@xyzzy.farnsworth.org>
Dale Farnsworth wrote:
> From: Gabriel Paubert <paubert@iram.es>
>
> There is no good reason for the asymmetry in the parameters of
> eth_port_uc_addr_get() and eth_port_uc_addr_set(). Make them
> symmetric. Remove some gratuitous block comments while we're here.
>
> Signed-off-by: Gabriel Paubert <paubert@iram.es>
> Signed-off-by: Dale Farnsworth <dale@farnsworth.org>
> ---
> This is a clean-up patch that needn't be rushed upstream. -Dale
>
> drivers/net/mv643xx_eth.c | 59 +++++++-----------------------------
> drivers/net/mv643xx_eth.h | 4 --
> 2 files changed, 13 insertions(+), 50 deletions(-)
applied to #upstream
next prev parent reply other threads:[~2007-03-29 12:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-23 12:30 [PATCH] Fix use of uninitialized field in mv643xx_eth Gabriel Paubert
2007-03-23 15:38 ` Dale Farnsworth
2007-03-23 19:03 ` [PATCH 1/2] mv643xx_eth: Fix use of uninitialized port_num field Dale Farnsworth
2007-03-23 19:07 ` [PATCH 2/2] mv643xx_eth: make eth_port_uc_addr_{get,set}() calls symmetric Dale Farnsworth
2007-03-29 12:35 ` Jeff Garzik [this message]
2007-03-28 6:19 ` [PATCH 1/2] mv643xx_eth: Fix use of uninitialized port_num field Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460BB286.2030706@garzik.org \
--to=jeff@garzik.org \
--cc=dale@farnsworth.org \
--cc=mlachwani@mvista.com \
--cc=netdev@vger.kernel.org \
--cc=paubert@iram.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).