* [PATCH] add Attansic L2 PCI ID
@ 2007-03-28 23:47 Chris Snook
2007-03-29 12:23 ` Jeff Garzik
0 siblings, 1 reply; 4+ messages in thread
From: Chris Snook @ 2007-03-28 23:47 UTC (permalink / raw)
To: jeff; +Cc: xiong.huang, jacliburn, netdev, csnook
From: Chris Snook <csnook@redhat.com>
Add PCI ID for the Attansic L2 100 Mb ethernet adapter.
Signed-off-by: Chris Snook <csnook@redhat.com>
--- linux-2.6.21-rc5.orig/include/linux/pci_ids.h 2007-03-27 23:26:50.000000000 -0400
+++ linux-2.6.21-rc5/include/linux/pci_ids.h 2007-03-28 15:11:03.000000000 -0400
@@ -2090,6 +2090,7 @@
#define PCI_VENDOR_ID_ATTANSIC 0x1969
#define PCI_DEVICE_ID_ATTANSIC_L1 0x1048
+#define PCI_DEVICE_ID_ATTANSIC_L2 0x2048
#define PCI_VENDOR_ID_JMICRON 0x197B
#define PCI_DEVICE_ID_JMICRON_JMB360 0x2360
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] add Attansic L2 PCI ID
2007-03-28 23:47 [PATCH] add Attansic L2 PCI ID Chris Snook
@ 2007-03-29 12:23 ` Jeff Garzik
2007-03-29 14:11 ` Chris Snook
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2007-03-29 12:23 UTC (permalink / raw)
To: Chris Snook; +Cc: xiong.huang, jacliburn, netdev
Chris Snook wrote:
> From: Chris Snook <csnook@redhat.com>
>
> Add PCI ID for the Attansic L2 100 Mb ethernet adapter.
>
> Signed-off-by: Chris Snook <csnook@redhat.com>
>
> --- linux-2.6.21-rc5.orig/include/linux/pci_ids.h 2007-03-27 23:26:50.000000000 -0400
> +++ linux-2.6.21-rc5/include/linux/pci_ids.h 2007-03-28 15:11:03.000000000 -0400
> @@ -2090,6 +2090,7 @@
>
> #define PCI_VENDOR_ID_ATTANSIC 0x1969
> #define PCI_DEVICE_ID_ATTANSIC_L1 0x1048
> +#define PCI_DEVICE_ID_ATTANSIC_L2 0x2048
Actually you should be doing the reverse:
Remove PCI_DEVICE_ID_ATTANSIC_L1, and replace the one place that uses it
with the hexadecimal constant.
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] add Attansic L2 PCI ID
2007-03-29 12:23 ` Jeff Garzik
@ 2007-03-29 14:11 ` Chris Snook
2007-03-29 18:56 ` Jeff Garzik
0 siblings, 1 reply; 4+ messages in thread
From: Chris Snook @ 2007-03-29 14:11 UTC (permalink / raw)
To: Jeff Garzik; +Cc: xiong.huang, jacliburn, netdev
Jeff Garzik wrote:
> Chris Snook wrote:
>> From: Chris Snook <csnook@redhat.com>
>>
>> Add PCI ID for the Attansic L2 100 Mb ethernet adapter.
>>
>> Signed-off-by: Chris Snook <csnook@redhat.com>
>>
>> --- linux-2.6.21-rc5.orig/include/linux/pci_ids.h 2007-03-27
>> 23:26:50.000000000 -0400
>> +++ linux-2.6.21-rc5/include/linux/pci_ids.h 2007-03-28
>> 15:11:03.000000000 -0400
>> @@ -2090,6 +2090,7 @@
>>
>> #define PCI_VENDOR_ID_ATTANSIC 0x1969
>> #define PCI_DEVICE_ID_ATTANSIC_L1 0x1048
>> +#define PCI_DEVICE_ID_ATTANSIC_L2 0x2048
>
> Actually you should be doing the reverse:
>
> Remove PCI_DEVICE_ID_ATTANSIC_L1, and replace the one place that uses it
> with the hexadecimal constant.
>
> Jeff
We're working on integrating the driver for the L2 chip, so it will be useful to
symbolically distinguish between them. For now, adding the ID serves to
document the distinction between the L1 and L2 chips, as they're alike enough
that an atl1 driver hacked with the new PCI ID will detect link status on the
L2, even though it won't really work. By getting the ID in now, we can
distribute patches that don't touch core code and won't need to be tweaked for
submission.
If pci_ids.h bloat is really a big deal, we can hold off until the L2 patches
are ready, but I don't see the harm in getting this out there now.
-- Chris
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] add Attansic L2 PCI ID
2007-03-29 14:11 ` Chris Snook
@ 2007-03-29 18:56 ` Jeff Garzik
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2007-03-29 18:56 UTC (permalink / raw)
To: Chris Snook; +Cc: xiong.huang, jacliburn, netdev
Chris Snook wrote:
> Jeff Garzik wrote:
>> Chris Snook wrote:
>>> From: Chris Snook <csnook@redhat.com>
>>>
>>> Add PCI ID for the Attansic L2 100 Mb ethernet adapter.
>>>
>>> Signed-off-by: Chris Snook <csnook@redhat.com>
>>>
>>> --- linux-2.6.21-rc5.orig/include/linux/pci_ids.h 2007-03-27
>>> 23:26:50.000000000 -0400
>>> +++ linux-2.6.21-rc5/include/linux/pci_ids.h 2007-03-28
>>> 15:11:03.000000000 -0400
>>> @@ -2090,6 +2090,7 @@
>>>
>>> #define PCI_VENDOR_ID_ATTANSIC 0x1969
>>> #define PCI_DEVICE_ID_ATTANSIC_L1 0x1048
>>> +#define PCI_DEVICE_ID_ATTANSIC_L2 0x2048
>>
>> Actually you should be doing the reverse:
>>
>> Remove PCI_DEVICE_ID_ATTANSIC_L1, and replace the one place that uses
>> it with the hexadecimal constant.
>>
>> Jeff
>
> We're working on integrating the driver for the L2 chip, so it will be
> useful to symbolically distinguish between them. For now, adding the ID
> serves to document the distinction between the L1 and L2 chips, as
> they're alike enough that an atl1 driver hacked with the new PCI ID will
> detect link status on the L2, even though it won't really work. By
> getting the ID in now, we can distribute patches that don't touch core
> code and won't need to be tweaked for submission.
>
> If pci_ids.h bloat is really a big deal, we can hold off until the L2
> patches are ready, but I don't see the harm in getting this out there now.
It is current policy that we do not add PCI ID symbols that are only
used in one place. It is pointless to add this.
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-03-29 18:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-28 23:47 [PATCH] add Attansic L2 PCI ID Chris Snook
2007-03-29 12:23 ` Jeff Garzik
2007-03-29 14:11 ` Chris Snook
2007-03-29 18:56 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).