* [NET_SCHED]: cls_basic: fix memory leak in basic_destroy
@ 2007-03-30 17:02 Patrick McHardy
2007-03-30 20:41 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Patrick McHardy @ 2007-03-30 17:02 UTC (permalink / raw)
To: David S. Miller; +Cc: Linux Netdev List
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 883 bytes --]
[NET_SCHED]: cls_basic: fix memory leak in basic_destroy
tp->root is not freed on destruction.
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
commit b3df7f810c71b213224c105283c01e57ba7ed46a
tree 7f49d1edbc955609e369317a5a76100c87082377
parent 167c6a396949ee921bf70cbe58529f8e4dd4398d
author Patrick McHardy <kaber@trash.net> Fri, 30 Mar 2007 15:46:00 +0200
committer Patrick McHardy <kaber@trash.net> Fri, 30 Mar 2007 15:46:00 +0200
net/sched/cls_basic.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/sched/cls_basic.c b/net/sched/cls_basic.c
index e76803c..c885412 100644
--- a/net/sched/cls_basic.c
+++ b/net/sched/cls_basic.c
@@ -110,6 +110,7 @@ static void basic_destroy(struct tcf_proto *tp)
list_del(&f->link);
basic_delete_filter(tp, f);
}
+ kfree(head);
}
static int basic_delete(struct tcf_proto *tp, unsigned long arg)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [NET_SCHED]: cls_basic: fix memory leak in basic_destroy
2007-03-30 17:02 [NET_SCHED]: cls_basic: fix memory leak in basic_destroy Patrick McHardy
@ 2007-03-30 20:41 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-03-30 20:41 UTC (permalink / raw)
To: kaber; +Cc: netdev
From: Patrick McHardy <kaber@trash.net>
Date: Fri, 30 Mar 2007 19:02:53 +0200
> [NET_SCHED]: cls_basic: fix memory leak in basic_destroy
>
> tp->root is not freed on destruction.
>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
Applied, thanks a lot Patrick.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-30 20:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-30 17:02 [NET_SCHED]: cls_basic: fix memory leak in basic_destroy Patrick McHardy
2007-03-30 20:41 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).