2.6.21-rc5-mm3: Why was my vioc cleanup patch dropped?

2.6.21-rc5-mm3: Why was my vioc cleanup patch dropped?

[Adrian Bunk]

On Fri, Mar 30, 2007 at 01:05:59AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.21-rc5-mm2:
>...
> -drivers-net-vioc-possible-cleanups.patch
>...
>  Merged into mainline or a subsystem tree.
>...

Please give me a clue:
- This patch is not merged into the netdev tree as included in -mm and
- it still applies fine against 2.6.21-rc5-mm3 and
- it still compiles fine with 2.6.21-rc5-mm3.

TIA
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

[-mm patch] make drivers/net/qla3xxx.c:PHY_DEVICES[] static

[Adrian Bunk]

On Fri, Mar 30, 2007 at 01:05:59AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.21-rc5-mm2:
>...
>  git-netdev-all.patch
>...
>  git trees
>...


This patch makes the needlessly global PHY_DEVICES[] static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

BTW: Why is the name uppercase?

--- linux-2.6.21-rc5-mm3/drivers/net/qla3xxx.c.old	2007-03-31 21:30:20.000000000 +0200
+++ linux-2.6.21-rc5-mm3/drivers/net/qla3xxx.c	2007-03-31 22:02:00.000000000 +0200
@@ -88,7 +88,7 @@
 	char 		*name;
 } PHY_DEVICE_INFO_t;
 
-const PHY_DEVICE_INFO_t PHY_DEVICES[] =
+static const PHY_DEVICE_INFO_t PHY_DEVICES[] =
 	{{PHY_TYPE_UNKNOWN,    0x000000, 0x0, "PHY_TYPE_UNKNOWN"},
 	 {PHY_VITESSE_VSC8211, 0x0003f1, 0xb, "PHY_VITESSE_VSC8211"},
 	 {PHY_AGERE_ET1011C,   0x00a0bc, 0x1, "PHY_AGERE_ET1011C"},

Re: [-mm patch] make drivers/net/qla3xxx.c:PHY_DEVICES[] static

[Jeff Garzik]

Adrian Bunk wrote:
> On Fri, Mar 30, 2007 at 01:05:59AM -0700, Andrew Morton wrote:
>> ...
>> Changes since 2.6.21-rc5-mm2:
>> ...
>>  git-netdev-all.patch
>> ...
>>  git trees
>> ...
> 
> 
> This patch makes the needlessly global PHY_DEVICES[] static.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> ---
> 
> BTW: Why is the name uppercase?

applied

RE: [-mm patch] make drivers/net/qla3xxx.c:PHY_DEVICES[] static

[Ron Mercer]

Adrian,

Sorry about the upper case stuff.  The new PHY code was ported from our
firmware guys and the case didn't not get changed.  I normally will make
such changes but it didn't get done this time.  I will clean it up in
the near future.

Ron 

> -----Original Message-----
> From: Jeff Garzik [mailto:jgarzik@pobox.com] 
> Sent: Tuesday, April 03, 2007 7:34 PM
> To: Adrian Bunk
> Cc: Andrew Morton; Linux Driver; 
> linux-kernel@vger.kernel.org; netdev@vger.kernel.org
> Subject: Re: [-mm patch] make 
> drivers/net/qla3xxx.c:PHY_DEVICES[] static
> 
> Adrian Bunk wrote:
> > On Fri, Mar 30, 2007 at 01:05:59AM -0700, Andrew Morton wrote:
> >> ...
> >> Changes since 2.6.21-rc5-mm2:
> >> ...
> >>  git-netdev-all.patch
> >> ...
> >>  git trees
> >> ...
> > 
> > 
> > This patch makes the needlessly global PHY_DEVICES[] static.
> > 
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > 
> > ---
> > 
> > BTW: Why is the name uppercase?
> 
> applied
> 
> 
>