From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [XFRM]: beet: fix worst case header_len calculation
Date: Mon, 09 Apr 2007 20:49:59 +0200 [thread overview]
Message-ID: <461A8AD7.90607@trash.net> (raw)
In-Reply-To: <20070409.114840.18284797.davem@davemloft.net>
David Miller wrote:
> From: Patrick McHardy <kaber@trash.net>
> Date: Sun, 08 Apr 2007 04:56:51 +0200
>
>
>>The pskb_copy_expand crash I was seeing was triggered by BEET
>>mode not calculating the SA's header_len value for the worst
>>case, causing skb headroom expansions. This patch uses the
>>worst case value by including the maximum length of the pseudo
>>header.
>>
>>The patch applies on top of the MTU optimization patch.
>
>
> Applied, thanks Patrick.
>
> Can you backport this to 2.6.21 for me, if you think we should
> bother? Thanks.
Its merely an optimization, so I don't think we should put it in 2.6.21
at this point in the release cycle.
next prev parent reply other threads:[~2007-04-09 18:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-08 2:56 [XFRM]: beet: fix worst case header_len calculation Patrick McHardy
2007-04-09 18:48 ` David Miller
2007-04-09 18:49 ` Patrick McHardy [this message]
2007-04-09 18:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461A8AD7.90607@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).