From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <shemminger@linux-foundation.org>
Subject: Re: udp checksum issue in netpoll mode.
Date: Thu, 12 Apr 2007 07:49:47 -0700
Message-ID: <461E470B.5060907@linux-foundation.org>
References: <6d6a94c50704120331m36957148iae111ab7324c88c2@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	Matt Mackall <mpm@selenic.com>, netdev@vger.kernel.org,
	Linux Kernel <linux-kernel@vger.kernel.org>
To: Aubrey Li <aubreylee@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from smtp.osdl.org ([65.172.181.24]:45255 "EHLO smtp.osdl.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750982AbXDLOty (ORCPT <rfc822;netdev@vger.kernel.org>);
	Thu, 12 Apr 2007 10:49:54 -0400
In-Reply-To: <6d6a94c50704120331m36957148iae111ab7324c88c2@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

Aubrey Li wrote:
> I think we discussed this issue before.
>
> The current checksum function doesn't consider the kind of packet
> which is padded to reach a specific minimum length. I believe that's
> the problem caused my test case failed. Is this issue fixed? Or is it
> acceptable if I make a patch not calculating this kind of packet?
>
> Thanks,
> -Aubrey
The caller should be trimming the packet and updating the hardware checksum
value (like the normal UDP path).