From: Andrew Lunn <andrew@lunn.ch>
To: netdev-bot+sashiko@kernel.org
Cc: hongmei.xu@oss.qualcomm.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
sagar.cheluvegowda@oss.qualcomm.com
Subject: Re: [PATCH net-next v2] net: phy: aquantia: Poll global status register for provision ID
Date: Sun, 15 Nov 2026 16:45:13 +0100 [thread overview]
Message-ID: <461d4b43-e9b4-4adc-8a98-066b60885758@lunn.ch> (raw)
In-Reply-To: <179473078423.2199510.11398825136938509686@kernel.org>
> > + if (val < 0)
> > + phydev_warn(phydev, "Failed to read VEND1_GLOBAL_RSVD_STAT1: %pe\n",
> > + ERR_PTR(val));
> > + else if (ret)
> > + phydev_warn(phydev, "Firmware provisioning ID not ready; "
> > + "interface mode detection may be incorrect\n");
>
> [Severity: Medium]
> If phy_read_mmd() fails while polling VEND1_GLOBAL_RSVD_STAT1, the
> val < 0 term ends read_poll_timeout() right away with ret == 0. The
> code then logs a warning and returns 0, so the MDIO error is lost.
This is one of the earliest reads from the device. If the MDIO bus is
going to fail, it will fail here, rather than later. So the error
handling should be correct. Please address this issue.
Andrew
prev parent reply other threads:[~2026-11-15 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 8:07 [PATCH net-next v2] net: phy: aquantia: Poll global status register for provision ID Hongmei Xu
2026-11-11 13:39 ` Andrew Lunn
2026-11-12 3:00 ` Hongmei Xu
2026-11-15 8:19 ` netdev-bot+sashiko
2026-11-15 15:45 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461d4b43-e9b4-4adc-8a98-066b60885758@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=hongmei.xu@oss.qualcomm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sagar.cheluvegowda@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox