From: Patrick McHardy <kaber@trash.net>
To: Jerome Borsboom <j.borsboom@erasmusmc.nl>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] parse ip:port strings correctly in in4_pton
Date: Mon, 16 Apr 2007 11:14:36 +0200 [thread overview]
Message-ID: <46233E7C.10407@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0704161001280.1519@knorkaan.xs4all.nl>
Jerome Borsboom wrote:
> in4_pton converts a textual representation of an ip4 address into an
> integer representation. However, when the textual representation is of
> in the form ip:port, c.f. 192.168.1.1:5060, and 'delim' is set to -1,
> the function bails out when parsing the colon.
>
> It makes sense to allow the colon as a delimiting character without
> explicitly having to set it through the 'delim' variable as there can be
> no ambiguity in the point where the ip address is completely parsed.
> Furthermore, this function is indeed called from nf_conntrack_sip.c in
> this way to parse textual ip:port combinations which fails as stated above.
What about IPv6? in6_pton behaves similar and is also used by
nf_conntrack_sip.
next prev parent reply other threads:[~2007-04-16 9:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-16 8:21 [PATCH] parse ip:port strings correctly in in4_pton Jerome Borsboom
2007-04-16 9:14 ` Patrick McHardy [this message]
2007-04-16 9:32 ` Jerome Borsboom
2007-04-17 8:27 ` Jerome Borsboom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46233E7C.10407@trash.net \
--to=kaber@trash.net \
--cc=j.borsboom@erasmusmc.nl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).