From: Patrick McHardy <kaber@trash.net>
To: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Cc: Christoph Hellwig <hch@infradead.org>,
netdev@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-2.6.22 1/3] [TCP]: Sed magic converts func(sk, tp, ...) -> func(sk, ...)
Date: Mon, 16 Apr 2007 16:41:23 +0200 [thread overview]
Message-ID: <46238B13.5070201@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0704161703170.28337@kivilampi-30.cs.helsinki.fi>
Ilpo Järvinen wrote:
> Tweaked newlines manually & fixed four warnings that were
> introduced.
Not all of them it seems:
> -static inline void tcp_fast_path_check(struct sock *sk, struct tcp_sock *tp)
> +static inline void tcp_fast_path_check(struct sock *sk)
> {
> + struct tcp_sock *tp = tcp_sk(sk);
^ missing newline
> if (skb_queue_empty(&tp->out_of_order_queue) &&
> tp->rcv_wnd &&
> atomic_read(&sk->sk_rmem_alloc) < sk->sk_rcvbuf &&
> @@ -778,18 +779,19 @@ static inline void tcp_minshall_update(s
> tp->snd_sml = TCP_SKB_CB(skb)->end_seq;
> }
>
> -static inline void tcp_check_probe_timer(struct sock *sk, struct tcp_sock *tp)
> +static inline void tcp_check_probe_timer(struct sock *sk)
> {
> + struct tcp_sock *tp = tcp_sk(sk);
^ same here .. quite a few follow
> const struct inet_connection_sock *icsk = inet_csk(sk);
> if (!tp->packets_out && !icsk->icsk_pending)
> inet_csk_reset_xmit_timer(sk, ICSK_TIME_PROBE0,
> icsk->icsk_rto, TCP_RTO_MAX);
> }
next prev parent reply other threads:[~2007-04-16 14:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-16 12:48 [PATCH net-2.6.22 1/3] [TCP]: Sed magic converts func(sk, tp, ...) -> func(sk, ...) Ilpo Järvinen
2007-04-16 12:48 ` [PATCH 2/3] [TCP]: Fix unused variable warnings (tcp_sock *tp no longer needed) Ilpo Järvinen
2007-04-16 12:48 ` [PATCH 3/3] [TCP]: Added emptylines after the new tcp_sock *tp initialization Ilpo Järvinen
2007-04-16 13:48 ` [PATCH net-2.6.22 1/3] [TCP]: Sed magic converts func(sk, tp, ...) -> func(sk, ...) Christoph Hellwig
2007-04-16 14:08 ` Ilpo Järvinen
2007-04-16 14:41 ` Patrick McHardy [this message]
2007-04-16 15:15 ` Ilpo Järvinen
2007-04-16 15:32 ` Patrick McHardy
2007-04-16 15:52 ` Ilpo Järvinen
2007-04-16 16:19 ` Ilpo Järvinen
2007-04-17 0:16 ` David Miller
2007-04-17 7:45 ` Ilpo Järvinen
2007-04-17 11:54 ` Ilpo Järvinen
2007-04-21 5:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46238B13.5070201@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=hch@infradead.org \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).