From: Pavel Emelianov <xemul@sw.ru>
To: David Miller <davem@davemloft.net>,
shemminger@linux-foundation.org,
Linux Netdev List <netdev@vger.kernel.org>
Cc: bridge@lists.osdl.org, devel@openvz.org
Subject: [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses
Date: Tue, 17 Apr 2007 15:49:30 +0400 [thread overview]
Message-ID: <4624B44A.9040509@sw.ru> (raw)
From: Evgeny Kravtsunov <emkravts@openvz.org>
compare_ether_addr() implicitly requires that the addresses
passed are 2-bytes aligned in memory.
This is not true for br_stp_change_bridge_id() and
br_stp_recalculate_bridge_id() in which one of the addresses
is unsigned char *, and thus may not be 2-bytes aligned.
Signed-off-by: Evgeny Kravtsunov <emkravts@openvz.org>
Signed-off-by: Kirill Korotaev <dev@openvz.org>
Signed-off-by: Pavel Emelianov <xemul@openvz.org>
---
--- a/net/bridge/br_stp_if.c 2006-09-20 07:42:06.000000000 +0400
+++ b/net/bridge/br_stp_if.c 2007-04-13 12:28:08.000000000 +0400
@@ -124,7 +124,9 @@ void br_stp_disable_port(struct net_brid
/* called under bridge lock */
void br_stp_change_bridge_id(struct net_bridge *br, const unsigned char *addr)
{
- unsigned char oldaddr[6];
+ /* should be aligned on 2 bytes for compare_ether_addr() */
+ unsigned short oldaddr_aligned[ETH_ALEN >> 1];
+ unsigned char *oldaddr = (unsigned char *)oldaddr_aligned;
struct net_bridge_port *p;
int wasroot;
@@ -149,11 +151,14 @@ void br_stp_change_bridge_id(struct net_
br_become_root_bridge(br);
}
-static const unsigned char br_mac_zero[6];
+/* should be aligned on 2 bytes for compare_ether_addr() */
+static const unsigned short br_mac_zero_aligned[ETH_ALEN >> 1];
/* called under bridge lock */
void br_stp_recalculate_bridge_id(struct net_bridge *br)
{
+ const unsigned char *br_mac_zero =
+ (const unsigned char *)br_mac_zero_aligned;
const unsigned char *addr = br_mac_zero;
struct net_bridge_port *p;
next reply other threads:[~2007-04-17 11:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-17 11:49 Pavel Emelianov [this message]
2007-04-17 19:31 ` [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses David Miller
2007-04-17 19:55 ` Stephen Hemminger
2007-04-17 20:09 ` David Miller
2007-04-17 20:37 ` Stephen Hemminger
2007-04-17 21:09 ` David Miller
2007-04-17 21:24 ` Eric Dumazet
2007-04-17 21:27 ` David Miller
2007-04-18 6:43 ` Pavel Emelianov
2007-04-18 8:28 ` David Miller
2007-04-18 8:37 ` Pavel Emelianov
2007-04-18 14:44 ` Stephen Hemminger
2007-04-18 20:04 ` David Miller
2007-04-19 14:14 ` Eric Dumazet
2007-04-19 18:18 ` Stephen Hemminger
2007-04-19 20:01 ` [BRIDGE] " David Miller
2007-04-19 20:29 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4624B44A.9040509@sw.ru \
--to=xemul@sw.ru \
--cc=bridge@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).