From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses Date: Tue, 17 Apr 2007 12:55:41 -0700 Message-ID: <4625263D.1000709@linux-foundation.org> References: <4624B44A.9040509@sw.ru> <20070417.123135.56861973.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: xemul@sw.ru, netdev@vger.kernel.org, bridge@lists.osdl.org, devel@openvz.org To: David Miller Return-path: Received: from smtp.osdl.org ([65.172.181.24]:60510 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161159AbXDQT4J (ORCPT ); Tue, 17 Apr 2007 15:56:09 -0400 In-Reply-To: <20070417.123135.56861973.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org David Miller wrote: > From: Pavel Emelianov > Date: Tue, 17 Apr 2007 15:49:30 +0400 > > >> From: Evgeny Kravtsunov >> >> compare_ether_addr() implicitly requires that the addresses >> passed are 2-bytes aligned in memory. >> >> This is not true for br_stp_change_bridge_id() and >> br_stp_recalculate_bridge_id() in which one of the addresses >> is unsigned char *, and thus may not be 2-bytes aligned. >> >> Signed-off-by: Evgeny Kravtsunov >> Signed-off-by: Kirill Korotaev >> Signed-off-by: Pavel Emelianov >> > > Patch applied, thank you. > I had a better way, I'll fix.