From: Pavel Emelianov <xemul@sw.ru>
To: David Miller <davem@davemloft.net>
Cc: shemminger@linux-foundation.org, netdev@vger.kernel.org,
bridge@lists.osdl.org, devel@openvz.org
Subject: Re: [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses
Date: Wed, 18 Apr 2007 12:37:27 +0400 [thread overview]
Message-ID: <4625D8C7.7040206@sw.ru> (raw)
In-Reply-To: <20070418.012804.95897126.davem@davemloft.net>
David Miller wrote:
> From: Pavel Emelianov <xemul@sw.ru>
> Date: Wed, 18 Apr 2007 10:43:56 +0400
>
>> [snip]
>>
>>> --- linux-2.6.orig/net/bridge/br_private.h 2007-04-17
>>> 13:26:48.000000000 -0700 +++ linux-2.6/net/bridge/br_private.h
>>> 2007-04-17 13:30:29.000000000 -0700 @@ -36,7 +36,7 @@
>>> {
>>> unsigned char prio[2];
>>> unsigned char addr[6];
>>> -};
>>> +} __attribute__((aligned(8)));
>> Why "8"? Mustn't it be "16"? Address is to be 2-bytes aligned...
>
> Actually it could be made "2", the aligned() attribute is
> in bytes, not bits.
Indeed :) My bad :( Thank you...
next prev parent reply other threads:[~2007-04-18 8:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-17 11:49 [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses Pavel Emelianov
2007-04-17 19:31 ` David Miller
2007-04-17 19:55 ` Stephen Hemminger
2007-04-17 20:09 ` David Miller
2007-04-17 20:37 ` Stephen Hemminger
2007-04-17 21:09 ` David Miller
2007-04-17 21:24 ` Eric Dumazet
2007-04-17 21:27 ` David Miller
2007-04-18 6:43 ` Pavel Emelianov
2007-04-18 8:28 ` David Miller
2007-04-18 8:37 ` Pavel Emelianov [this message]
2007-04-18 14:44 ` Stephen Hemminger
2007-04-18 20:04 ` David Miller
2007-04-19 14:14 ` Eric Dumazet
2007-04-19 18:18 ` Stephen Hemminger
2007-04-19 20:01 ` [BRIDGE] " David Miller
2007-04-19 20:29 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4625D8C7.7040206@sw.ru \
--to=xemul@sw.ru \
--cc=bridge@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).