netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: Andrew Morton <akpm@osdl.org>, netdev@vger.kernel.org, santil@us.ibm.com
Subject: Re: [PATCH] Fix sparse errors in drivers/net/ibmveth.c
Date: Tue, 24 Apr 2007 14:02:41 -0400	[thread overview]
Message-ID: <462E4641.6060604@pobox.com> (raw)
In-Reply-To: <20070417031314.BC404DDED4@ozlabs.org>

Michael Ellerman wrote:
> drivers/net/ibmveth.c:96:46: error: marked inline, but without a definition
> drivers/net/ibmveth.c:96: warning: 'ibmveth_rxq_harvest_buffer' declared inline after being called
> drivers/net/ibmveth.c:96: warning: previous declaration of 'ibmveth_rxq_harvest_buffer' was here
> 
> Just let the compiler decide, as it happens gcc 4.~ inlines it anyway.
> 
> drivers/net/ibmveth.c:957:71: warning: Using plain integer as NULL pointer
> drivers/net/ibmveth.c:964:85: warning: Using plain integer as NULL pointer
> 
> Split the long lines as well, ugly, but < 80 columns.
> 
> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>

applied



      reply	other threads:[~2007-04-24 18:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-17  3:12 [PATCH] Fix sparse errors in drivers/net/ibmveth.c Michael Ellerman
2007-04-24 18:02 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=462E4641.6060604@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=akpm@osdl.org \
    --cc=michael@ellerman.id.au \
    --cc=netdev@vger.kernel.org \
    --cc=santil@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).