From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] netdev: get rid of casts Date: Tue, 24 Apr 2007 14:07:32 -0400 Message-ID: <462E4764.6000107@garzik.org> References: <20070424104650.3523479d@dxpl.pdx.osdl.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: David Miller , netdev@vger.kernel.org To: Stephen Hemminger Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:40432 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422968AbXDXSHf (ORCPT ); Tue, 24 Apr 2007 14:07:35 -0400 In-Reply-To: <20070424104650.3523479d@dxpl.pdx.osdl.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Stephen Hemminger wrote: > The following casts are unnecessary, just passing void * will do. > > Signed-off-by: Stephen Hemminger > --- > net/core/dev.c | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/net/core/dev.c b/net/core/dev.c > index 18c51b4..61e9da2 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -1981,7 +1981,7 @@ int register_gifconf(unsigned int family, gifconf_func_t * gifconf) > * match. --pb > */ > > -static int dev_ifname(struct ifreq __user *arg) > +static int dev_ifname(void __user *arg) > { > struct net_device *dev; > struct ifreq ifr; > @@ -2014,7 +2014,7 @@ static int dev_ifname(struct ifreq __user *arg) > * Thus we will need a 'compatibility mode'. > */ > > -static int dev_ifconf(char __user *arg) > +static int dev_ifconf(void __user *arg) > { > struct ifconf ifc; > struct net_device *dev; > @@ -2778,12 +2778,12 @@ int dev_ioctl(unsigned int cmd, void __user *arg) > > if (cmd == SIOCGIFCONF) { > rtnl_lock(); > - ret = dev_ifconf((char __user *) arg); > + ret = dev_ifconf(arg); > rtnl_unlock(); > - return ret; > } > + > if (cmd == SIOCGIFNAME) > - return dev_ifname((struct ifreq __user *)arg); > + return dev_ifname(arg); Seems like a net loss of information, with your patch. The casts are adding missing type information, in this case. Certainly it is more for human consumption than compiler consumption, but nonetheless... Jeff