From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Acker Subject: Re: [RFT] e100 driver on ARM Date: Thu, 26 Apr 2007 09:41:22 -0400 Message-ID: <4630AC02.7040706@roinet.com> References: <44FC0261.6010807@garzik.org> <20060904123123.GB1285@xi.wantstofly.org> <460AF480.7050609@intel.com> <460B4BF2.1070803@roinet.com> <20070329141041.GA3510@csclub.uwaterloo.ca> <46239138.4040408@roinet.com> <20070417173507.GB5575@csclub.uwaterloo.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Kok, Auke" , Lennert Buytenhek , Jeff Garzik , Netdev List , Linux Kernel , Andrew Morton , Russell King To: Lennart Sorensen Return-path: Received: from static-72-92-88-10.phlapa.fios.verizon.net ([72.92.88.10]:52018 "EHLO smtp.roinet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754786AbXDZNkz (ORCPT ); Thu, 26 Apr 2007 09:40:55 -0400 In-Reply-To: <20070417173507.GB5575@csclub.uwaterloo.ca> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Lennart Sorensen wrote: > Well the IT8152G+PXA255 combination used on the SBC we tried a couple of > years ago did not work. The PCI bus had errors and the SBC maker gave > up trying to fix it. We switched to a Geode SC1200 based board instead > which works fine PCI wise. > I don't think this is it. Other PCI devices work fine on this board include several 802.11 radios. The S-bit patch totally fixes the problem. Here is a quote from Russell that describes what I believe is the main problem: http://www-gatago.com/linux/kernel/15457063.html " Has e100 actually been fixed to use the PCI DMA API correctly yet? Looking at it, it doesn't look like it, so until it does, eepro100 is the far better bet for platforms needing working DMA API. What I'm talking about is e100's apparant belief that it can modify rfd's in the receive ring on a non-cache coherent architecture and expect the data around it to remain unaffected (see e100_rx_alloc_skb): struct rfd { u16 status; u16 command; u32 link; u32 rbd; u16 actual_size; u16 size; }; it touches command and link. This means that the whole rfd plus maybe the following or preceding 16 bytes get loaded into a cache line (assuming cache lines of 32 bytes), and that data written out again at sync. However, it does this on what seems to be an active receive chain. So, both the CPU _and_ the device own the same data. Which is a violation of the DMA API. " I think that the S-bit patch fixes it because the hardware spins on the s-bit instead of using the packet. With just the el-bit, the hardware tries to use the same cache line that the software is updating. Can someone from Intel let us know if I understand the hardware's handling of the S and EL bits? If my interpretation is correct, can the s-bit patch be applied? It seems like the correct way to lock out the hardware while a packet is being updated. I have not seen a reason given not to apply the patch. -Ack