From: Ayaz Abdulla <aabdulla@nvidia.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: akpm@linux-foundation.org, netdev@vger.kernel.org, mingo@elte.hu
Subject: Re: [patch 09/11] forcedeth: improve NAPI logic
Date: Thu, 26 Apr 2007 10:53:04 -0400 [thread overview]
Message-ID: <4630BCD0.9040702@nvidia.com> (raw)
In-Reply-To: <4630EE50.4000109@garzik.org>
Jeff Garzik wrote:
> Ayaz Abdulla wrote:
>
>> I don't see why the NAPI handler needs to process tx packets. The ISR
>> will handle all tx processing.
>
>
> It is a design choice, not a requirement.
>
> Moving non-RX interrupt processing to the NAPI handler can help as loads
> increase. The basic idea is to do as much work as possible in the NAPI
> handler with NIC interrupts masked. That mitigates global system
> per-interrupt overhead even more than an only-RX NAPI scheme.
>
> Several net drivers do TX completion handling in the NAPI handler.
Ok. In that case, the patch needs to be improved.
The following needs to be done when NAPI is enabled:
- remove the tx handling within the ISRs
- mask off the tx interrupts within the ISRs that handle tx processing
- re-enable tx interrupts within the NAPI handler
- add tx handling within the NAPI handler (this patch covers it)
>
> Jeff
>
>
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
next prev parent reply other threads:[~2007-04-26 18:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-26 7:23 [patch 09/11] forcedeth: improve NAPI logic akpm
2007-04-26 14:30 ` Ayaz Abdulla
2007-04-26 18:24 ` Jeff Garzik
2007-04-26 14:53 ` Ayaz Abdulla [this message]
2007-04-27 12:27 ` Jeff Garzik
2007-04-27 18:57 ` Lennart Sorensen
2007-04-28 0:10 ` Jeff Garzik
2007-04-28 0:25 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4630BCD0.9040702@nvidia.com \
--to=aabdulla@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).