From: Chuck Ebbert <cebbert@redhat.com>
To: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Cc: Netdev <netdev@vger.kernel.org>
Subject: IPV6 source routing patch is still broken?
Date: Thu, 26 Apr 2007 17:53:58 -0400 [thread overview]
Message-ID: <46311F76.9040803@redhat.com> (raw)
Looking at the patch that went into 2.6.20.9, I can't see
how type 2 packets get through at all. Shouldn't this part
read:
+ case IPV6_SRCRT_TYPE_2:
+ if (accept_source_route >= 0)
+ break;
+ kfree_skb(skb);
+ return -1;
+ case IPV6_SRCRT_TYPE_0:
+ if (accept_source_route > 0)
+ break;
+ kfree_skb(skb);
+ return -1;
And what does this do?
+ switch (hdr->type) {
+#ifdef CONFIG_IPV6_MIP6
+ break;
+#endif
break by itself like that doesn't do anything. If it did
then people with mobile ipv6 enabled would always accept all
source routing. (They should at least know that's a problem.)
next reply other threads:[~2007-04-26 21:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-26 21:53 Chuck Ebbert [this message]
2007-04-26 22:04 ` IPV6 source routing patch is still broken? David Miller
2007-04-26 23:10 ` Chuck Ebbert
2007-04-26 23:52 ` YOSHIFUJI Hideaki / 吉藤英明
2007-04-27 2:29 ` David Miller
2007-04-26 22:31 ` David Miller
2007-04-26 22:57 ` Chuck Ebbert
2007-04-27 9:08 ` David Miller
2007-04-27 9:36 ` YOSHIFUJI Hideaki / 吉藤英明
2007-04-27 9:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46311F76.9040803@redhat.com \
--to=cebbert@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).