Netdev List
 help / color / mirror / Atom feed
From: Kyle Switch <kyle.switch@motor-comm.com>
To: Conor Dooley <conor@kernel.org>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, andrew@lunn.ch,
	hkallweit1@gmail.com, linux@armlinux.org.uk,
	Frank.Sae@motor-comm.com, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	ming.xu@motor-comm.com, xiaolin.xu@motor-comm.com,
	jianmin.wang@motor-comm.com, jie.han@motor-comm.com
Subject: Re: [PATCH net-next v21 1/3] dt-bindings: net: Document Motorcomm YT8824 PHY package
Date: Tue, 29 Sep 2026 08:49:32 +0800	[thread overview]
Message-ID: <46319153-5dd8-42f4-bd3d-c01e122cf218@motor-comm.com> (raw)
In-Reply-To: <20260928-valium-gents-cbf9a4fdbdcc@spud>


On 9/29/26 00:25, Conor Dooley wrote:
> On Mon, Sep 28, 2026 at 09:43:48AM +0800, Kyle Switch wrote:
>
>>>> +unevaluatedProperties: false
>>>> +
>>>> +examples:
>>>> +  - |
>>>> +    mdio {
>>>> +        #address-cells = <1>;
>>>> +        #size-cells = <0>;
>>>> +
>>>> +        ethernet-phy-package@9 {
>>>> +            #address-cells = <1>;
>>>> +            #size-cells = <0>;
>>>> +            compatible = "motorcomm,yt8824-package";
>>>> +            reg = <9>;
>>>> +
>>>> +            phy-mode = "internal";
>>>> +
>>>> +            ethernet-phy@4 {
>>>> +                reg = <4>;
>>>> +            };
>>>> +
>>>> +            ethernet-phy@5 {
>>>> +                reg = <5>;
>>>> +            };
>>>> +
>>>> +            ethernet-phy@6 {
>>>> +                reg = <6>;
>>>> +            };
>>>> +
>>>> +            ethernet-phy@7 {
>>>> +                reg = <7>;
>>>> +            };
>>> Unless the addresses and numbers of phys are entirely unconstrained, I
>>> think you should add some pattern properties for them.
>> Ans: I'm somewhat confused on this point. What might the pattern properties
> There's no need for this "ans" business, the quoting makes it clear
> already.
okay, thank you.
>>          you mentioned include? Could you provide more detail? thank you.
> On second thoughts, there's some basic constraints already provided by
> ethernet-phy-package for this. Probably don't need to anyhting specific.
>
okay, based on your suggestions, the next version will be modified.

  reply	other threads:[~2026-09-29  0:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24  7:50 [PATCH net-next v21 0/3] net: phy: Add driver for Motorcomm Quad 2.5GbE phy Kyle Switch
2026-09-24  7:50 ` [PATCH net-next v21 1/3] dt-bindings: net: Document Motorcomm YT8824 PHY package Kyle Switch
2026-09-24 17:07   ` Conor Dooley
2026-09-24 19:16     ` Andrew Lunn
2026-09-28  1:45       ` Kyle Switch
2026-09-28  3:28         ` Kyle Switch
2026-09-28 16:54           ` Andrew Lunn
2026-09-29  0:46             ` Kyle Switch
2026-09-28  1:43     ` Kyle Switch
2026-09-28 16:25       ` Conor Dooley
2026-09-29  0:49         ` Kyle Switch [this message]
2026-09-28  7:53   ` netdev-bot+sashiko
2026-09-24  7:50 ` [PATCH net-next v21 2/3] net: phy: Add support for Template Control register for PMA Kyle Switch
2026-09-28  7:53   ` netdev-bot+sashiko
2026-09-24  7:50 ` [PATCH net-next v21 3/3] net: phy: Add driver for Motorcomm Quad 2.5GbE phy Kyle Switch
2026-09-28  7:53   ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46319153-5dd8-42f4-bd3d-c01e122cf218@motor-comm.com \
    --to=kyle.switch@motor-comm.com \
    --cc=Frank.Sae@motor-comm.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=jianmin.wang@motor-comm.com \
    --cc=jie.han@motor-comm.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=ming.xu@motor-comm.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=xiaolin.xu@motor-comm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox