* [patch 02/11] vioc-warning-fix
@ 2007-04-26 7:23 akpm
2007-04-28 0:27 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2007-04-26 7:23 UTC (permalink / raw)
To: jeff; +Cc: netdev, akpm, driver-support, schidambaram
From: Andrew Morton <akpm@linux-foundation.org>
Fix this, on i386:
drivers/net/vioc/vioc_transmit.c: In function 'vioc_tx_interrupt':
drivers/net/vioc/vioc_transmit.c:387: warning: cast from pointer to integer of different size
I dunno what the driver is trying to do here, but it looks unpleasant.
Cc: Sriram Chidambaram <schidambaram@fabric7.com>
Cc: Fabric7 Driver-Support <driver-support@fabric7.com>
Cc: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/net/vioc/vioc_vnic.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff -puN drivers/net/vioc/vioc_vnic.h~vioc-warning-fix drivers/net/vioc/vioc_vnic.h
--- a/drivers/net/vioc/vioc_vnic.h~vioc-warning-fix
+++ a/drivers/net/vioc/vioc_vnic.h
@@ -103,11 +103,11 @@
)
#define VIOC_IRQ_PARAM_VIOC_ID(param) \
- (int) (((u64) param >> 28) & 0xf)
+ (int) (((long) param >> 28) & 0xf)
#define VIOC_IRQ_PARAM_INTR_ID(param) \
- (int) ((u64) param & 0xffff)
+ (int) ((long) param & 0xffff)
#define VIOC_IRQ_PARAM_PARAM_ID(param) \
- (int) (((u64) param >> 16) & 0xff)
+ (int) (((long) param >> 16) & 0xff)
#define VIOC_IRQ_PARAM_SET(vioc, intr, param) \
((((u64) vioc & 0xf) << 28) | \
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 02/11] vioc-warning-fix
2007-04-26 7:23 [patch 02/11] vioc-warning-fix akpm
@ 2007-04-28 0:27 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-04-28 0:27 UTC (permalink / raw)
To: akpm; +Cc: netdev, driver-support, schidambaram
akpm@linux-foundation.org wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
>
> Fix this, on i386:
>
> drivers/net/vioc/vioc_transmit.c: In function 'vioc_tx_interrupt':
> drivers/net/vioc/vioc_transmit.c:387: warning: cast from pointer to integer of different size
>
> I dunno what the driver is trying to do here, but it looks unpleasant.
>
> Cc: Sriram Chidambaram <schidambaram@fabric7.com>
> Cc: Fabric7 Driver-Support <driver-support@fabric7.com>
> Cc: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/net/vioc/vioc_vnic.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
applied these three vioc patches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-04-28 0:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-26 7:23 [patch 02/11] vioc-warning-fix akpm
2007-04-28 0:27 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).