netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <dada1@cosmosbay.com>
To: David Miller <davem@davemloft.net>
Cc: brian.haley@hp.com, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org
Subject: Re: [RFC, PATCH] IPV6 : add 64 bits components in struct in6_addr to speedup ipv6_addr_equal() & ipv6_addr_any()
Date: Mon, 30 Apr 2007 21:08:45 +0200	[thread overview]
Message-ID: <46363EBD.1020102@cosmosbay.com> (raw)
In-Reply-To: <20070430.115937.104035556.davem@davemloft.net>

David Miller a écrit :
> From: Brian Haley <brian.haley@hp.com>
> Date: Mon, 30 Apr 2007 12:27:07 -0400
> 
>> The problem is that drivers don't necessarily align the address on the 
>> correct boundary, so on some 64-bit arches this could be fatal.  There's 
>> ways around it since I did it in a previous life, but you'd need to copy 
>> the addresses and hide them in the skb in the rare case, neither of 
>> which is a great thing to do.
> 
> Yes, the majority of the network drivers are only ensuring 32-bit
> alignment after the ethernet header currently on receive.  They
> were designed with ipv4 in mind long ago and then the logic just
> gets copied everywhere.
> 
> 

Yes I see...

Maybe we could at least define a 'struct in6_addr_k' for internal structures 
only, to speedup some parts of IPV6 stack.




  reply	other threads:[~2007-04-30 19:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-30 14:28 [RFC, PATCH] IPV6 : add 64 bits components in struct in6_addr to speedup ipv6_addr_equal() & ipv6_addr_any() Eric Dumazet
2007-04-30 16:09 ` YOSHIFUJI Hideaki / 吉藤英明
2007-04-30 16:27 ` Brian Haley
2007-04-30 18:59   ` David Miller
2007-04-30 19:08     ` Eric Dumazet [this message]
2007-04-30 19:22       ` David Miller
2007-04-30 19:10 ` David Miller
2007-04-30 21:34   ` Andi Kleen
2007-04-30 20:37     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46363EBD.1020102@cosmosbay.com \
    --to=dada1@cosmosbay.com \
    --cc=brian.haley@hp.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).