* [PATCH 1/20][BNX2]: Block MII access when ifdown.
@ 2007-05-02 1:12 Michael Chan
2007-05-02 6:58 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Michael Chan @ 2007-05-02 1:12 UTC (permalink / raw)
To: davem, netdev
[BNX2]: Block MII access when ifdown.
The device may be in D3hot state and should not allow MII register
access.
Signed-off-by: Michael Chan <mchan@broadcom.com>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index f98a220..9f0a067 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -5562,6 +5562,9 @@ bnx2_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
case SIOCGMIIREG: {
u32 mii_regval;
+ if (!netif_running(dev))
+ return -EAGAIN;
+
spin_lock_bh(&bp->phy_lock);
err = bnx2_read_phy(bp, data->reg_num & 0x1f, &mii_regval);
spin_unlock_bh(&bp->phy_lock);
@@ -5575,6 +5578,9 @@ bnx2_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
if (!capable(CAP_NET_ADMIN))
return -EPERM;
+ if (!netif_running(dev))
+ return -EAGAIN;
+
spin_lock_bh(&bp->phy_lock);
err = bnx2_write_phy(bp, data->reg_num & 0x1f, data->val_in);
spin_unlock_bh(&bp->phy_lock);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/20][BNX2]: Block MII access when ifdown.
2007-05-02 1:12 [PATCH 1/20][BNX2]: Block MII access when ifdown Michael Chan
@ 2007-05-02 6:58 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-05-02 6:58 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev
Michael Chan wrote:
> [BNX2]: Block MII access when ifdown.
>
> The device may be in D3hot state and should not allow MII register
> access.
>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
ACK 1-2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-05-02 6:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-02 1:12 [PATCH 1/20][BNX2]: Block MII access when ifdown Michael Chan
2007-05-02 6:58 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).