From: Jeff Garzik <jeff@garzik.org>
To: Michael Chan <mchan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH 14/20][BNX2]: Re-structure the 2.5G Serdes code.
Date: Wed, 02 May 2007 03:14:47 -0400 [thread overview]
Message-ID: <46383A67.8050407@garzik.org> (raw)
In-Reply-To: <1178068571.4820.50.camel@dell>
Michael Chan wrote:
> diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
> index c6310ae..f2d248f 100644
> --- a/include/linux/ethtool.h
> +++ b/include/linux/ethtool.h
> @@ -434,6 +434,7 @@ struct ethtool_ops {
> #define SUPPORTED_10000baseT_Full (1 << 12)
> #define SUPPORTED_Pause (1 << 13)
> #define SUPPORTED_Asym_Pause (1 << 14)
> +#define SUPPORTED_2500baseX_Full (1 << 15)
>
> /* Indicates what features are advertised by the interface. */
> #define ADVERTISED_10baseT_Half (1 << 0)
> @@ -451,6 +452,7 @@ struct ethtool_ops {
> #define ADVERTISED_10000baseT_Full (1 << 12)
> #define ADVERTISED_Pause (1 << 13)
> #define ADVERTISED_Asym_Pause (1 << 14)
> +#define ADVERTISED_2500baseX_Full (1 << 15)
Please don't sneak in ethtool userspace API changes like this. NAK.
The normal procedure for doing something like this is to create a
separate patch and post it on netdev. HOPEFULLY with the associated
change to the ethtool(8) utility, to keep it in sync with the kernel.
Otherwise, adding the above definition is useless to most users. See
http://sf.net/projects/gkernel/ or
git://git.kernel.org/pub/scm/network/ethtool/ethtool.git for ethtool
source code.
I ACK the changes to bnx2 outside of this, though.
prev parent reply other threads:[~2007-05-02 7:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 1:16 [PATCH 14/20][BNX2]: Re-structure the 2.5G Serdes code Michael Chan
2007-05-02 7:14 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46383A67.8050407@garzik.org \
--to=jeff@garzik.org \
--cc=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).