From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [NETFILTER] sip: Fix RTP address NAT
Date: Wed, 02 May 2007 15:19:21 +0200 [thread overview]
Message-ID: <46388FD9.1030907@trash.net> (raw)
In-Reply-To: <20070502040102.GA28343@gondor.apana.org.au>
Herbert Xu wrote:
> [NETFILTER] sip: Fix RTP address NAT
>
> I needed to use this recently to talk to a Cisco server. In my case
> I only did SNAT while the Cisco server used a different address for
> RTP traffic than the one for SIP. I discovered that nf_nat_sip NATed
> the RTP address to the SIP one which was unnecessary but OK. However,
> in doing so it did not DNAT the destination address on the RTP traffic
> to the Cisco back to the original RTP address.
>
> This patch corrects this by noting down the RTP address and using it
> when the expectation fires.
Applied, thanks a lot Herbert. My last attempt at fixing this resulted
in a patch that was too ugly to live :)
prev parent reply other threads:[~2007-05-02 13:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 4:01 [NETFILTER] sip: Fix RTP address NAT Herbert Xu
2007-05-02 13:19 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46388FD9.1030907@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).