From: Patrick McHardy <kaber@trash.net>
To: hadi@cyberus.ca
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH][XFRM] SAD info TLV aggregation
Date: Thu, 03 May 2007 15:15:59 +0200 [thread overview]
Message-ID: <4639E08F.5030101@trash.net> (raw)
In-Reply-To: <1178197316.4077.4.camel@localhost>
jamal wrote:
> On Thu, 2007-03-05 at 02:15 +0200, Patrick McHardy wrote:
>
>
>>I think using attributes here
>
>
> "here" as in SAD or SPD as well?
Both.
>> wasn't a bad idea since this exports
>>things that are implementation details and might need to be changed
>>or extended at some point.
>
>
> I think it may be reasonable to group the Hash info in one TLV
> and the IPSEC specific info in a separate TLV - is this what you are
> saying? Be explicit so i dont have to redo the patch over and over.
Yes, thats what I imagined too.
> The other way to look at it is in the future, a new TLV could be added
> that replaces the current one.
It would still make sense to seperate hash related things from the
SA count in my opinion.
>>In any case consistent naming here would be nice (SAD_ vs. SADXXX).
>
>
> yes, i need to make this change on the SPD as well. Dave hold onto both
> patches - i will resend.
Thanks.
next prev parent reply other threads:[~2007-05-03 13:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 22:18 [PATCH][XFRM] SAD info TLV aggregation jamal
2007-05-03 0:15 ` Patrick McHardy
2007-05-03 13:01 ` jamal
2007-05-03 13:15 ` Patrick McHardy [this message]
2007-05-03 13:26 ` jamal
2007-05-03 20:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4639E08F.5030101@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).