netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: hadi@cyberus.ca
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [RESEND][PATCH][XFRM] SAD info TLV aggregation
Date: Fri, 04 May 2007 02:19:03 +0200	[thread overview]
Message-ID: <463A7BF7.5010604@trash.net> (raw)
In-Reply-To: <1178233601.4068.2.camel@localhost>

jamal wrote:
>  enum xfrm_sadattr_type_t {
> -	XFRMA_SAD_UNSPEC,
> -	XFRMA_SADHMASK,
> -	XFRMA_SADHMAX,
> +	XFRMA_SADUNSPEC,
>  	XFRMA_SADCNT,
> +	XFRMA_SADHINFO,
>  	__XFRMA_SAD_MAX
>  
>  #define XFRMA_SAD_MAX (__XFRMA_SAD_MAX - 1)


I don't want to annoy you unnecessarily, but this still has
the same inconsistent naming (XFRMA_SAD.. vs. XFRMA_SAD_MAX),
just one spot less, which is at least confusing to remember
(as user of an API things like this also tend to make me
suspicious of its quality).

If you dont mind I'm just going to resend myself with fixed
names tomorrow so you don't have to bother doing this again.


  reply	other threads:[~2007-05-04  0:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-03 23:06 [RESEND][PATCH][XFRM] SAD info TLV aggregation jamal
2007-05-04  0:19 ` Patrick McHardy [this message]
2007-05-04  0:50   ` jamal
2007-05-04  0:52     ` David Miller
2007-05-04  1:01       ` jamal
2007-05-04  1:44         ` jamal
2007-05-04  3:36           ` David Miller
2007-05-04 18:10     ` Patrick McHardy
2007-05-04 19:55       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=463A7BF7.5010604@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=hadi@cyberus.ca \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).