From: Patrick McHardy <kaber@trash.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: git-net locking bustage
Date: Fri, 04 May 2007 21:02:56 +0200 [thread overview]
Message-ID: <463B8360.10805@trash.net> (raw)
In-Reply-To: <20070504115316.998c7fd3.akpm@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 153 bytes --]
Andrew Morton wrote:
> kernel BUG at net/netlink/af_netlink.c:144!
The BUG_ON(mutex_is_locked(nlk_sk(sk)->cb_mutex)) is bogus,
this patch removes it.
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 1009 bytes --]
[NETLINK]: Remove bogus BUG_ON
Remove bogus BUG_ON(mutex_is_locked(nlk_sk(sk)->cb_mutex)), when the
netlink_kernel_create caller specifies an external mutex it might
validly be locked.
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
commit c83f581b321efb7e7119c9f906ba8ecb6c43541d
tree 4430e76db65599f1c02d1eaeec0b0606ea167175
parent 572b08f6ad7d473edd282fd40ceadbb4dce522a2
author Patrick McHardy <kaber@trash.net> Fri, 04 May 2007 21:02:24 +0200
committer Patrick McHardy <kaber@trash.net> Fri, 04 May 2007 21:02:24 +0200
net/netlink/af_netlink.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index ac1cead..507828d 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -142,7 +142,6 @@ static void netlink_sock_destruct(struct sock *sk)
{
struct netlink_sock *nlk = nlk_sk(sk);
- BUG_ON(mutex_is_locked(nlk_sk(sk)->cb_mutex));
if (nlk->cb) {
if (nlk->cb->done)
nlk->cb->done(nlk->cb);
next prev parent reply other threads:[~2007-05-04 19:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 18:53 git-net locking bustage Andrew Morton
2007-05-04 19:02 ` Patrick McHardy [this message]
2007-05-04 19:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=463B8360.10805@trash.net \
--to=kaber@trash.net \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).