From: Jeff Garzik <jeff@garzik.org>
To: Michael Chan <mchan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH 8/11][TG3]: Add TG3_FLAG_SUPPORT_MSI flag.
Date: Fri, 04 May 2007 20:38:43 -0400 [thread overview]
Message-ID: <463BD213.2070004@garzik.org> (raw)
In-Reply-To: <1178326494.4859.24.camel@dell>
Michael Chan wrote:
> @@ -10404,6 +10400,8 @@ static void __devinit tg3_read_fw_ver(struct tg3 *tp)
> }
> }
>
> +static struct pci_dev * __devinit tg3_find_peer(struct tg3 *);
> +
> static int __devinit tg3_get_invariants(struct tg3 *tp)
> {
> static struct pci_device_id write_reorder_chipsets[] = {
Prototypes are better kept at the top of the file, grouped together. It
can sometimes be a pain later on, if they are scattered throughout a big
source file like tg3.c.
ACK the patch's content of course
next prev parent reply other threads:[~2007-05-05 0:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-05 0:54 [PATCH 8/11][TG3]: Add TG3_FLAG_SUPPORT_MSI flag Michael Chan
2007-05-05 0:38 ` Jeff Garzik [this message]
2007-05-05 20:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=463BD213.2070004@garzik.org \
--to=jeff@garzik.org \
--cc=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).