* Re: [patch 089/181] Blackfin: on-chip ethernet MAC controller driver
[not found] <200705062150.l46LoVWQ024648@shell0.pdx.osdl.net>
@ 2007-05-07 0:20 ` Jeff Garzik
2007-05-07 3:40 ` Randy Dunlap
[not found] ` <1179909013.10328.9.camel@roc-desktop>
1 sibling, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2007-05-07 0:20 UTC (permalink / raw)
To: akpm; +Cc: torvalds, bryan.wu, netdev
akpm@linux-foundation.org wrote:
> From: "Wu, Bryan" <bryan.wu@analog.com>
>
> This patch implements the driver necessary use the Analog Devices
> Blackfin processor's on-chip ethernet MAC controller.
>
> Signed-off-by: Bryan Wu <bryan.wu@analog.com>
> Cc: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/net/Kconfig | 44 +
> drivers/net/Makefile | 1
> drivers/net/bfin_mac.c | 981 +++++++++++++++++++++++++++++++++++++++
> drivers/net/bfin_mac.h | 147 +++++
> 4 files changed, 1173 insertions(+)
WTF?
Why are new network drivers not going to me, netdev, and/or DaveM?
Something is really broken here. What is it?
I NAK this driver purely on the basis of lack of review.
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 089/181] Blackfin: on-chip ethernet MAC controller driver
2007-05-07 0:20 ` [patch 089/181] Blackfin: on-chip ethernet MAC controller driver Jeff Garzik
@ 2007-05-07 3:40 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2007-05-07 3:40 UTC (permalink / raw)
To: Jeff Garzik; +Cc: akpm, torvalds, bryan.wu, netdev
On Sun, 06 May 2007 20:20:40 -0400 Jeff Garzik wrote:
> akpm@linux-foundation.org wrote:
> > From: "Wu, Bryan" <bryan.wu@analog.com>
> >
> > This patch implements the driver necessary use the Analog Devices
> > Blackfin processor's on-chip ethernet MAC controller.
> >
> > Signed-off-by: Bryan Wu <bryan.wu@analog.com>
> > Cc: Jeff Garzik <jeff@garzik.org>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > ---
> >
> > drivers/net/Kconfig | 44 +
> > drivers/net/Makefile | 1
> > drivers/net/bfin_mac.c | 981 +++++++++++++++++++++++++++++++++++++++
> > drivers/net/bfin_mac.h | 147 +++++
> > 4 files changed, 1173 insertions(+)
>
> WTF?
>
> Why are new network drivers not going to me, netdev, and/or DaveM?
because people are dumping Everything to lkml :(
> Something is really broken here. What is it?
Use netdev, linux-scsi, linux-ide, linux-usb-devel, linux-ieee1394,
etc., instead of one-list-fits-all.
> I NAK this driver purely on the basis of lack of review.
Yep.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 089/181] Blackfin: on-chip ethernet MAC controller driver
[not found] ` <465405A1.5030409@garzik.org>
@ 2007-05-23 9:16 ` Bryan Wu
0 siblings, 0 replies; 3+ messages in thread
From: Bryan Wu @ 2007-05-23 9:16 UTC (permalink / raw)
To: Jeff Garzik; +Cc: LKML, netdev, torvalds, akpm
On Wed, 2007-05-23 at 05:13 -0400, Jeff Garzik wrote:
> Bryan Wu wrote:
> > Hi Jeff:
> >
> > Could you please review this patch? Sorry for miss sending the patch to
> > you for review at beginning.
>
> can you resend as a patch rather than a quoted patch?
>
> Jeff
>
>
Oh, sorry, I forgot this. It will be sent ASAP.
Thanks Jeff,
-Bryan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-05-23 9:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200705062150.l46LoVWQ024648@shell0.pdx.osdl.net>
2007-05-07 0:20 ` [patch 089/181] Blackfin: on-chip ethernet MAC controller driver Jeff Garzik
2007-05-07 3:40 ` Randy Dunlap
[not found] ` <1179909013.10328.9.camel@roc-desktop>
[not found] ` <465405A1.5030409@garzik.org>
2007-05-23 9:16 ` Bryan Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).